Closed Bug 1028085 Opened 7 years ago Closed 7 years ago

rewrite Makefile of camera app in javascript


(Firefox OS Graveyard :: Gaia::Build, defect)

Not set


(Not tracked)

2.0 S6 (18july)


(Reporter: yurenju, Assigned: yurenju)



(Whiteboard: [p=3])


(1 file)

we found a way to load r.js in xpcshell javascript for gaia build environment, so let rewrite it to accomplish bug 1022516.
Assignee: nobody → yurenju.mozilla
Hi djf, I'm working on this issue and have a pull request for that. Our goal is migrating build script to javascript as possible as we can, then we can get faster build process and have the compatibility to build gaia in firefox exntension.

but I'm not sure if you have any concern to keep using Makefile, so I would like to get your feedback here, thanks!
Attachment #8446433 - Flags: feedback?(dflanagan)
Comment on attachment 8446433 [details] [review]
github PR:

Yuren: I don't know anything about the camera app's new build system.

Diego: can you take this feedback request or pass it on to Wilson or Justin, please?
Attachment #8446433 - Flags: feedback?(dflanagan) → feedback?(dmarcos)
discussed with Deigo on email and he wants to keep Makefile since we may use an external repository for camera app.

Alex, what do you think? we may use a config file to decide executing a command for building app such as |make| or require build.js module in gaia build environment, but build system will depend on |make| which is we want to avoid.
Flags: needinfo?(poirot.alex)
The easiest to unblock you is probably to keep the current Makefile and commit your build.js script. I will rewrite the Makefile to be completely XPCSHELLSDK agnostic. What do you think?
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8446433 [details] [review]
github PR:

having two ways for same purpose will take extra effort to maintain them, but it can help us solve this conflict now.

I will update my pull request and send feedback request again.
Attachment #8446433 - Flags: feedback?(dmarcos)
Flags: needinfo?(yurenju.mozilla)
Flags: needinfo?(poirot.alex)
Target Milestone: --- → 2.0 S6 (18july)
Whiteboard: [p=3]
Comment on attachment 8446433 [details] [review]
github PR:


Pull request has been updated, Makefile is restored so we only added build.js for camera app, and we no longer execute app Makefile on bug 1035722.


could you reivew this pr? and I added build.js in this pull request but didn't remove Makefile, so to verify this pr you need to remove apps/camera/Makefile to test it until bug 1035722 landed.
Attachment #8446433 - Flags: review?(gduan)
Attachment #8446433 - Flags: feedback?(dmarcos)
Comment on attachment 8446433 [details] [review]
github PR:

LGTM, just a small nit. r=gduan
Attachment #8446433 - Flags: review?(gduan) → review+
nit is addressed.
Attachment #8446433 - Flags: feedback?(dmarcos) → feedback+
merged, thanks, George & Diego!
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.