1028085 - rewrite Makefile of camera app in javascript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

we found a way to load r.js in xpcshell javascript for gaia build environment, so let rewrite it to accomplish bug 1022516.

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/21023

Hi djf, I'm working on this issue and have a pull request for that. Our goal is migrating build script to javascript as possible as we can, then we can get faster build process and have the compatibility to build gaia in firefox exntension.

but I'm not sure if you have any concern to keep using Makefile, so I would like to get your feedback here, thanks!

Comment 2

[David Flanagan [:djf]]

Comment on attachment 8446433 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21023

Yuren: I don't know anything about the camera app's new build system.

Diego: can you take this feedback request or pass it on to Wilson or Justin, please?

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

discussed with Deigo on email and he wants to keep Makefile since we may use an external repository for camera app.

Alex, what do you think? we may use a config file to decide executing a command for building app such as |make| or require build.js module in gaia build environment, but build system will depend on |make| which is we want to avoid.

Comment 4

[Diego Marcos [:dmarcos]]

The easiest to unblock you is probably to keep the current Makefile and commit your build.js script. I will rewrite the Makefile to be completely XPCSHELLSDK agnostic. What do you think?

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8446433 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21023

having two ways for same purpose will take extra effort to maintain them, but it can help us solve this conflict now.

I will update my pull request and send feedback request again.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

try server:

https://tbpl.mozilla.org/?rev=b8674d5d06a86edd1a1e6364f2cf7cb1705c1c64&tree=Gaia-Try

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8446433 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21023

Deigo,

Pull request has been updated, Makefile is restored so we only added build.js for camera app, and we no longer execute app Makefile on bug 1035722.

George,

could you reivew this pr? and I added build.js in this pull request but didn't remove Makefile, so to verify this pr you need to remove apps/camera/Makefile to test it until bug 1035722 landed.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8446433 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/21023

LGTM, just a small nit. r=gduan

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

nit is addressed.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged, thanks, George & Diego!

https://github.com/mozilla-b2g/gaia/commit/95b340f76362cbccf29aa5d39c1ba8627b8a9eb4

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

backout and land again since I forget squash commits.

https://github.com/mozilla-b2g/gaia/commit/44f2678d8c3d88f717604b0a140bcc2280bcb239