1028113 - [Flatfish][FTU] When the tutorial screen finishing and entering the home screen, it displays error message 'File not found'.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[eva.chen.fx]

Attachment: file not found.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36

Steps to reproduce:

Reproducible: Always

1. Flash a fresh build on the tablet. Begin navigation through the first time setup screen.
2. Tap Next button until brought to the "tutorial" screen.
3. Press "Start tour" and press Next until completed.
4. One finger swipe up from the bottom edge to enter home screen.

-----------------------------------------
Environment Informations:
DUT: Tablet
Gaia: 8ccac0744848bd3ceaa6aa1c972ae0eb1e9ddc1e
B2G: 2.1.0.0-prerelease
firmware revision: flatfish_20140620-0110
Platform version : 33.0a1
Builder Identifier: 20140620011836


Actual results:

When the tutorial screen finishing and entering the home screen, it displays error message 'file not found'. It will be normal when we restart the tablet.


Expected results:

Home screen is properly loaded.

Comment 2

[Andrew Zhi]

reference:
Bug 1018854 - Start the migration after upgrading
Bug 1017069 - home1 to home2 Data Migration

is it possible to set vertical homescreen by default on large devices?
if no,maybe we should skip mechanism to migrate collections to datastores on tablet,
and the issue will be fixed.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1021327#c14
let's continue to use horizontal homescreen for now before there is a new design for tablet

so responding to comment 2, it sounds reasonable to skip the migration mechanism 
Thanks

Comment 4

[William Liang]

Agree. We also have the same conclusion internally to keep it running in landscape mode, and will skip the migration process as a work-around.

Comment 5

[Andrew Zhi]

Model:flatfish
Os Version:2.1.0.0-prerelease
gaia commit id:1c9eb3d1

1.update/replace gaia on the flatfish:
use GAIA_DEVICE_TYPE=tablet make reset-gaia
DON’T use NOFTU=1 to skip FTU app

2.and follow these steps,can reproduce the issue:
(from comment #0)
> 2. Tap Next button until brought to the "tutorial" screen.
> 3. Press "Start tour" and press Next until completed.
> 4. One finger swipe up from the bottom edge to enter home screen.
>

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

not sure what information is required from me?

Comment 7

[Andrew Zhi]

Attachment: patch:pull request

Comment 8

[Carmen Jimenez Cabezas]

Comment on attachment 8461359 [details] [review]
patch:pull request

The proposed patch distinguish just between low-res devices and all of the rest. While all the current phones we have now fall into this cathegory, I don't really feel comfortable doing this (mostly because I don't know the specs of the new phones coming out soon). Isn't there a more reliable way to distinguish between phone and tablet? Worst come to worse we can always just add a setting to build/config/tablet/settings.json (something like ftu.dontRunHomescreenMigration) and check that to decide if we should run the migration or not.

Comment 9

[Andrew Zhi]

Running the migration is because we need to update default homescreen:apps/homescreen -> apps/verticalhome ,
If the homescreen.appName exist and the value is “homescreen” in /build/config/<devices type>/setting.json ,
We don’t need to run the migration.
What do you think?

Now,the question is how to get the name of default homescreen within FTU app?
any idea?

Comment 10

[Andrew Zhi]

trace code...

loadConfig() @apps/ftu/js/tutorial.js :272
  -> currentLayout = ScreenLayout.getCurrentLayout() === 'tiny' ? 'tiny' : 'large';
  -> var configUrl = '/config/' + currentLayout + '.json';

steps[]@apps/ftu/config/tiny.json :5,21,33
  -> "video": "/style/images/tutorial/VerticalScroll.mp4"

FTU app has defined if the currentLayout is “tiny”,the device will use verticalhome app,
maybe the variable of currentLayout,can decide if we should run or not

Comment 11

[Carmen Jimenez Cabezas]

The settings.json file is added to the build settings and it's loaded into the Settings database before Gaia starts running. 
So to get that value, just use the Settings API. See for example http://mxr.mozilla.org/gaia/source/apps/system/js/operator_variant/operator_variant.js#50

(In reply to Andrew Zhi from comment #9)
> Running the migration is because we need to update default
> homescreen:apps/homescreen -> apps/verticalhome ,
> If the homescreen.appName exist and the value is “homescreen” in
> /build/config/<devices type>/setting.json ,
> We don’t need to run the migration.
> What do you think?
> 
> Now,the question is how to get the name of default homescreen within FTU app?
> any idea?

Comment 12

[Carmen Jimenez Cabezas]

As for the tiny and large.json, they're just for the tutorial configuration. And there's nothing that actually forbids having the horizontal homescreen on a tiny device (tarako comes to mind). If you use that to infer if you should launch or not the migration, then you add a side effect. While if you just add a build time setting (as you said in comment 9) then you have something that's specific for the use you need (and doesn't have any side effects). 

In fact, you don't even need to add a new setting, come to think about it. There's a setting (homescreen.manifestURL) that already holds the homescreen that will be loaded. So you just have to get the value of that setting and if it´s 'app://verticalhome.gaiamobile.org/manifest.webapp' then launch the migration process and otherwise don't

(In reply to Andrew Zhi from comment #10)
> trace code...
> 
> loadConfig() @apps/ftu/js/tutorial.js :272
>   -> currentLayout = ScreenLayout.getCurrentLayout() === 'tiny' ? 'tiny' :
> 'large';
>   -> var configUrl = '/config/' + currentLayout + '.json';
> 
> steps[]@apps/ftu/config/tiny.json :5,21,33
>   -> "video": "/style/images/tutorial/VerticalScroll.mp4"
> 
> FTU app has defined if the currentLayout is “tiny”,the device will use
> verticalhome app,
> maybe the variable of currentLayout,can decide if we should run or not

Comment 14

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

https://github.com/mozilla-b2g/gaia/pull/22299

Comment 15

[Carmen Jimenez Cabezas]

Comment on attachment 8464583 [details] [review]
Pull request

Why didn't you use the homescreen.manifestURL setting to decide if the update process should launch or not, as suggested by comment 12? 
This patch just moves the logic to another place, but it's basically the same as the one from comment 7. 

And as I said before, I don't really feel comfortable adding this extra meaning to the screen size. Specially not when we already have a setting that specifies which homescreen is going to be loaded.

The value for vertical is: 'homescreen.manifestURL': 'app://verticalhome.gaiamobile.org/manifest.webapp'

Comment 16

[Sherman Chen [:chens] (inactive)]

Can't really see what's happened from comment 7 since it's squashed, but if that's the case, I think Andrew's patch works, right?

Comment 17

[Sherman Chen [:chens] (inactive)]

ni for comment 16

Comment 18

[Fernando Campo (:fcampo)]

Comment on attachment 8464583 [details] [review]
Pull request

I left a comment on github to test both possibilities, but I'll let Carmen handle this as she has more experience on the matter.

Comment 19

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request 2

Comments addressed and update pull request

Comment 20

[Carmen Jimenez Cabezas]

Comment on attachment 8466010 [details] [review]
Pull request 2

Some comments in Github, Please take a look and ask me again to review when ready. thanks

Comment 21

[Sherman Chen [:chens] (inactive)]

Thanks for the comments, please take a look on updated pull request.

Comment 22

[Carmen Jimenez Cabezas]

Comment on attachment 8466010 [details] [review]
Pull request 2

Almost there! I left some comments for the tests in github. 
Please take a look and ask for review again when they're done. Thank you!

Comment 23

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8466010 [details] [review]
Pull request 2

Comments addressed, please take a look on updated pull request, thanks.

Comment 24

[Carmen Jimenez Cabezas]

Comment on attachment 8466010 [details] [review]
Pull request 2

Good job! This looks great! Thank you (only one nit comment on GH)
I've tested it with and without migration over a flame with homescreenURL set as verticalhome and homescreen, but I don't have a Flatfish to test it.
If you think that it should be tested over Flatfish, please ask Fernando to do it

Comment 25

[Sherman Chen [:chens] (inactive)]

Merged to master
https://github.com/mozilla-b2g/gaia/commit/0ead2fe435278dd9038a040cd480b2fab607a153

Comment 26

[eva.chen.fx]

The issue is resolved with a TCP build from today's master.
Verified on my Flatfish.
BuildID: 20140807004959
Gaia: 256cb6bff259ba4552b0c3d4f0b4d4e72452843c
Gecko:f822655e4e9ba34625dbad1ac2a69258751828d6
Version: 34.0a1