1028670 - [Collection app] Preinstalled SCs are ignored by app population and SC list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

Two cases which might be of the same cause:
1. Preinstalled SCs aren't deduped from "Add SCs" list
2. Preinstalled SCs do not get auto populated with related apps. For instance, Preinstalled Social SC, doesn't get added with Facebook app once installed.

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Also, it's icon never gets updated when changes occur in it's content.

Comment 2

[Jason Smith [:jsmith]]

Parity issue with the old homescreen.

Comment 4

[Kevin Grandon :kgrandon]

I'll take this.

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey - could one of you guys review this? Thanks!

Comment 6

[Kevin Grandon :kgrandon]

The above pull request fixes the fact that we were storing the pre installed collection IDs as strings instead of integers. This was causing an installed.indexOf() check to fail. Changing these in the manifest is likely the best option.

It probably solves a bunch of issues, but I'm not sure if it solves the native auto-population. I'll look into that as a follow-up, or in another bug if it's complex.

Comment 7

[Kevin Grandon :kgrandon]

Turns out the nativeInfo wasn't being populated due to cName not being there. Adding this at build seems like the easiest fix, and it works.

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8444783 [details] [review]
Github pull request

Before landing it I would like you take a look to migration process because the cName is new for 2.0

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/migrator.js#L61

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L147

Maybe you need to add something like

descriptor.cName = descriptor.categoryId = data.experienceId || descriptor.categoryId;

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Cristian, shouldn't it be:
descriptor.cName = descriptor.name

How can I go about testing migration from any version to 2.0?

Comment 10

[Cristian Rodriguez (:crdlc)]

Please Carmen explain to Ran how you did it if he needs it but basically via OTA from 1.3 or 1.4 to 2.0. Although honestly this could be very difficult to create an OTA bla bla. My recommendation would be that you read the structure that you will receive in the datastore after migrating bug 1019534 and add the cName or what you need to the descriptor

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/migrator.js#L61

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L147

(In reply to Ran Ben Aharon (Everything.me) from comment #9)
> Cristian, shouldn't it be:
> descriptor.cName = descriptor.name
> 
> How can I go about testing migration from any version to 2.0?

Comment 11

[Ran Ben Aharon [:ranbena] EverythingMe]

Gotcha. So Kevin, plz edit this line
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid_components.js#L145
to
descriptor.name = descriptor.cName = data.name;

Comment 12

[Carmen Jimenez Cabezas]

You can simulate an update from 1.3/1.4 to 2.0/master with the following steps:

- Install a complete build of 1.X (gaia & gecko)
- Pass the FTE and add whatever you need
- make a build of gecko in master (just run build.sh)
- When it has finished flash only gecko, and ensure that it doesn't start (flash.sh gecko && adb shell stop b2g)
- In your clone of gaia, edit isUpgrade function in version_helper.js file in <gaiaDir>/shared/js
  (https://github.com/mozilla-b2g/gaia/blob/master/shared/js/version_helper.js#L32) 
  and change "return isUpgrade" for "return true".  It's a little ugly, I  know, but it's the more easy method to simulate an upgrade. The correct method would be to make and OTA but...
- Now, you need to tell to the phone that it's first run, we can do this deleting gecko.buildID pref. I suggest you to use the Antonio's script (https://github.com/AntonioMA/gaiatools/blob/master/resetApps.sh).
  summing up:
  To put gaia execute: resetApp.sh && make install-gaia install-default-data

(In reply to Cristian Rodriguez (:crdlc) from comment #10)
> Please Carmen explain to Ran how you did it if he needs it but basically via
> OTA from 1.3 or 1.4 to 2.0. Although honestly this could be very difficult
> to create an OTA bla bla. My recommendation would be that you read the
> structure that you will receive in the datastore after migrating bug 1019534
> and add the cName or what you need to the descriptor
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/migrator.
> js#L61
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/
> grid_components.js#L147
> 
> (In reply to Ran Ben Aharon (Everything.me) from comment #9)
> > Cristian, shouldn't it be:
> > descriptor.cName = descriptor.name
> > 
> > How can I go about testing migration from any version to 2.0?

Comment 13

[Kevin Grandon :kgrandon]

Thanks guys. I updated the homescreen migration descriptor path, and will look at performing an OTA update today to make sure everything works.

Comment 14

[Ran Ben Aharon [:ranbena] EverythingMe]

Oh wow. What a relief that I don't have to get into that! :D

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8444783 [details] [review]
Github pull request

Ok - so long story short I'm having trouble faking the OTA upgrades as mentioned in this thread. The tips Carmen provided were very useful, but I think for now I'd like to get this in and test a real OTA update to 2.0 which is fairly straightforward.

In the meantime I'm investigating what we can do from marionette JS to simulate an upgrade.

Comment 16

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8444783 [details] [review]
Github pull request

LGTM, many thanks

Comment 17

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/bd5888a2c883712d07a058e4600bfa04b8b19af4

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/c478c43229883cee2afd09c6edb42d29a46cc500

Comment 19

[Elie]

Attachment: VIDEO0110_Compress.MP4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2