1030743 - NullPointerExceptions in GeckoPreferences

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

reported through google play

We're calling GeckoAppShell.getContext(), but GeckoPreferences is a context so we shouldn't need to.

java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.firefox_beta/org.mozilla.gecko.preferences.GeckoPreferences}: java.lang.NullPointerException
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2249)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2299)
at android.app.ActivityThread.access$700(ActivityThread.java:154)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1284)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:5306)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1102)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:869)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at org.mozilla.gecko.GeckoAppShell.getContext(GeckoAppShell.java:2070)
at org.mozilla.gecko.preferences.GeckoPreferences.getTextBox(GeckoPreferences.java:634)
at org.mozilla.gecko.preferences.GeckoPreferences.onCreateDialog(GeckoPreferences.java:705)
at android.app.Activity.onCreateDialog(Activity.java:3029)
at android.app.Activity.createDialog(Activity.java:1010)
at android.app.Activity.restoreManagedDialogs(Activity.java:999)
at android.app.Activity.performRestoreInstanceState(Activity.java:945)
at android.app.Instrumentation.callActivityOnRestoreInstanceState(Instrumentation.java:1148)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2227)
... 11 more

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: NPE_getContext_GeckoPreferences.patch

Comment 2

[Aaron Train [:aaronmt]]

Dupe of bug 1025931 in which you've already written and attached a patch?

Comment 3

[Ed Morley [:emorley]]

Push backed out for robocop-1 failures in testMasterPassword:
https://tbpl.mozilla.org/php/getParsedLog.php?id=42625238&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=42624677&tree=Fx-Team

remote:   https://hg.mozilla.org/integration/fx-team/rev/18afe25e9df9
remote:   https://hg.mozilla.org/integration/fx-team/rev/cf633fa6f40b
remote:   https://hg.mozilla.org/integration/fx-team/rev/a033a0b332eb

Comment 4

[Richard Newman [:rnewman]]

Brad's original landing:

 https://hg.mozilla.org/integration/fx-team/rev/1bb1e5ed3272

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f65faec9280

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8446529 [details] [diff] [review]
NPE_getContext_GeckoPreferences.patch

Review of attachment 8446529 [details] [diff] [review]:
-----------------------------------------------------------------

Top crash in the android play store reporting (before our crash reporting gets hooked up)

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8446529 [details] [diff] [review]
NPE_getContext_GeckoPreferences.patch

Simple fix. Approved for Beta and Aurora.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d08d6c52e2f4
https://hg.mozilla.org/releases/mozilla-beta/rev/69c528dbed04