1030996 - Add in tool notifications

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P1)

Description

[Rebecca Billings [:rbillings]]

With import of uBgzilla tasks, we will need to be able to serve notifications inside of the tool. For example, if a user takes a task and another user closes the Bugzilla bug we will need to notify the One and Done user that their task is now closed.

There are other use cases of how/why we'd want to send a notification to a user, but this is the primary one.

Comment 1

[Bob Silverberg [:bsilverberg]]

As this is a P1, and blocks a couple of other bugs, we need detailed requirements for this ASAP. Let me know if you want to schedule a meeting to discuss it.

Comment 2

[Rebecca Billings [:rbillings]]

In tool notifications:
- display as a pop up or window that must be acknowledged in order to dismiss it
- initial implementation is for imported bug tasks which have been closed in bugzilla, but it should be designed for broader messaging
- notifications happen automatically if tasks are closed/marked as draft/ marked as invalid when a user already has it open
- notification appears upon log in if user has an open task which now has invalid/draft status
- text:

[link Name of Task] task has been closed. Please select a new task. The task was closed because it was already complete or is no longer valid. 
                                                                         [button Pick a task to do]

- button takes users to Available tasks page

This may need more discussion- I'm more than willing to meet. An 'OK' button may be more flexible than the Pick a Task button. I will file a separate bug for completed Bugzilla tasks.

Comment 3

[Rebecca Billings [:rbillings]]

- Notification should also happen for expired tasks

Comment 4

[Bob Silverberg [:bsilverberg]]

Allow me to reiterate, in my own words, to make sure I understand what you want:

1. The first and only notification to be implemented for v2m2 will be a notification that a task that was previously open for a user is now closed. That closure could be the result of a Bugzilla bug being closed (for an imported task), the task being marked as draft or invalid, or the task becoming expired.
2. Notifications which appear for a user will be modal in nature, not allowing a user to do anything other than acknowledge the notification, which will be done via an "OK" button.
3. After dismissing the "closed task" notification the user will be taken to the Available Tasks page. In the future a developer can write code to allow different types of notifications to redirect users to different locations.
4. As soon as a previously open task is marked as no longer open (for any of the reasons mentioned above), the user will be notified.

Please confirm that this matches the requirements you documented above.

Comment 5

[Rebecca Billings [:rbillings]]

That does match- thanks. For 3, I would add that in the future it would be notifications with different text, more than different redirects- but that can all be sorted out later.

Comment 6

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/155

This is the PR I sent you an email about, Mike. It's actually ready for a review, as opposed to just feedback (I think).

Comment 7

[Osmose [:osmose, :mkelly]]

Comment on attachment 8455011 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/155

r-, left a bunch of feedback on some different ways of handling the feature.

I also have some feedback on the feature itself. It seems we're treating the "user must press ok to continue" thing as a hard requirement; they must be able to do nothing if they don't press ok.

I think that's a little excessive, and instead we should show the modal, let the user press ok, but not worry about edge cases like refreshing the page or whatever. The modal can also be something that shows over the current page, and then gets dismissed without redirecting the user. It's a little weird to force all users back to the Available Tasks view regardless of what they were attempting to do.

This also helps the implementation; we could show the notification in the same way that we show other notifications currently, and implement the modal popup and confirmation with JavaScript / CSS instead of having backend code changes to ensure that the user clicks OK.

Thoughts?

Comment 8

[Osmose [:osmose, :mkelly]]

Comment on attachment 8455011 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/155

r+'d on Github

Comment 9

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8455011 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/155

Landed in https://github.com/mozilla/oneanddone/commit/ef215b7bc0b1adb10ea2fb4443b4f908fabca00e

Comment 10

[Bob Silverberg [:bsilverberg]]

This has been pushed to dev and stage. The implementation is a bit different from above. When a user has an open Attempt, and the Task for that Attempt becomes unavailable (e.g., it expires or is marked as a draft), the user will receive a notification on the next request that they make. This will take the form of a modal dialog that is displayed over the page that was generated via that request. When they click OK the modal dialog disappears leaving them at that page. This seems like a friendlier route to take, rather than forcing them to the Available Tasks page regardless of what they were doing.

In order to test/verify the new behaviour, I suggest using two browsers. One for the user and one for an administrator. That way you can log in as a user, take a task, and then in a different browser update the task to make it no longer available (either via the start/end date or by marking it as a draft). When you go back to the user browser, whichever page you navigate to next will display the notification.

Comment 11

[Rebecca Billings [:rbillings]]

Tested on .paas.allizom.org. Verified that notifications display correctly, and must be clicked [ok or close button]. User is not sent to the tasks page, which I agree is preferable. Verified user gets message if task status changes while still logged in. Verified that if user is looking at a task detail page they get a page not found error if the status changes & then they try to take the task. Verified that user gets notification upon login if the status was changed.

The invalid task status will need to be tested later, but as part of the import feature- implementing notifications has been done.

Comment 12

[Rebecca Billings [:rbillings]]

Verified on production after setting draft and expiration dates- all notifications worked as expected.