Closed
Bug 1027890
Opened 10 years ago
Closed 10 years ago
Reject building with pymake
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
14.39 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
13.04 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Now that comm-central builds fine without pymake, it's time to say goodbye. And in fact, since bug 1022348 landed, pymake builds are broken anyways (and the good thing is that few people complained they were failing to build).
Assignee | ||
Comment 1•10 years ago
|
||
Also, not having to care for pymake helps make the build system changes I'm planning for soon.
Comment 2•10 years ago
|
||
I'll grant r+ without seeing the patch.
Comment 3•10 years ago
|
||
We need to ensure l10n and related infra (including release jobs) will work fine without pymake, even when calling the old pymake invoker directly (e.g. python ...make.py) for certain buildbot parts.
I "seem to recall" that we passed directly to mozmake when invoked that way, if in path, but wanted to call it out
Assignee | ||
Comment 4•10 years ago
|
||
We can surely do this in several steps:
- Remove pymake support from mach (doesn't impact automation)
- Make the change from bug 927672 not fallback to using pymake if mozmake is not present (and here we can see if that breaks l10n)
- Actively reject pymake in config/baseconfig.mk.
For step 2, that essentially depends on whether those builds are using tooltool or not.
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #4)
> For step 2, that essentially depends on whether those builds are using
> tooltool or not.
According to the logs, l10n builds don't use tooltool. (not only on windows, btw)
Assignee | ||
Comment 6•10 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1027929#c1
Oh, the irony. It would break nightly l10n, but not release l10n.
Assignee | ||
Comment 7•10 years ago
|
||
Actually, release l10n builds would break for a different reason: they don't run tooltool in the topsrcdir.
Assignee | ||
Comment 8•10 years ago
|
||
Please do look at this patch ;)
Attachment #8443377 -
Flags: review?(gps)
Assignee | ||
Comment 9•10 years ago
|
||
Note the weird thing removed from config/rules.mk ; the test didn't work there because L10NBASEDIR is always set (see config/config.mk)
Attachment #8443379 -
Flags: review?(gps)
Comment 10•10 years ago
|
||
Comment on attachment 8443377 [details] [diff] [review]
Reject builds with pymake
Review of attachment 8443377 [details] [diff] [review]:
-----------------------------------------------------------------
I think I have a new favorite patch of the year.
::: config/baseconfig.mk
@@ +29,3 @@
> # strictly above 4.0.
> +ifdef .PYMAKE
> +$(error Pymake is not supported)
Let's make this a little more user friendly since I know some people bypass client.mk and will see this. How about:
Pymake is no longer supported. Please upgrade to MozillaBuild 1.9 or newer and build with 'make'.
Attachment #8443377 -
Flags: review?(gps) → review+
Updated•10 years ago
|
Attachment #8443379 -
Flags: review?(gps) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/59b0072d64aa next to bug 1027497 for B2G Windows build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=42399092&tree=Mozilla-Inbound
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 13•10 years ago
|
||
What failed at landing is that the b2g simulator thing is back-calling make through the mach code in build_xpi.py. The best idea I have is to export MAKE, and make mach try that value too.
Attachment #8445628 -
Flags: review?(gps)
Assignee | ||
Updated•10 years ago
|
Attachment #8443377 -
Attachment is obsolete: true
Assignee | ||
Comment 14•10 years ago
|
||
Flags: needinfo?(mh+mozilla)
Comment 15•10 years ago
|
||
Comment on attachment 8445628 [details] [diff] [review]
Reject builds with pymake
Review of attachment 8445628 [details] [diff] [review]:
-----------------------------------------------------------------
my reluctant r+ on that b2g simulator patch comes back to bite us.
I'll re-land this for you since I assume you are sleeping.
Attachment #8445628 -
Flags: review?(gps) → review+
Comment 16•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/8aac3c8dc7bb
(inbound was closed)
Status: NEW → ASSIGNED
Assignee | ||
Comment 17•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
Comment 19•10 years ago
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•