Fix jshint error for build/download-manager.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: yurenju, Assigned: xfq, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor-lang=zh])

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
xfq
: review+
Details | Review | Splinter Review
+++ This bug was initially created as a clone of Bug #1032004 +++
Mentor: yurenju.mozilla
Whiteboard: [good first bug][mentor-lang=zh]

Comment 1

4 years ago
Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
(Assignee)

Comment 2

4 years ago
Created attachment 8464018 [details] [review]
PR on GitHub
Attachment #8464018 - Flags: review?(yurenju.mozilla)
Assignee: nobody → xfq.free
Comment on attachment 8464018 [details] [review]
PR on GitHub

:xfq,

since we don't use Cr for download-manager.js, could you remove Cr from it? and it will look like:

set me review again if pull request is updated.
Attachment #8464018 - Flags: review?(yurenju.mozilla)
sorry, it will looks like:

> const { Cc, Ci, Cu } = require('chrome');
(Assignee)

Comment 5

4 years ago
Comment on attachment 8464018 [details] [review]
PR on GitHub

Done, thanks.
Attachment #8464018 - Flags: review?(yurenju.mozilla)
Comment on attachment 8464018 [details] [review]
PR on GitHub

looks good, please squash to one commit and needinfo? me, I will help to merge it. r=yurenju
Attachment #8464018 - Flags: review?(yurenju.mozilla) → review+
Flags: needinfo?(xfq.free)
(Assignee)

Comment 7

4 years ago
Created attachment 8482173 [details] [review]
PRv2 on GitHub

I tried |git rebase -i| but accidentally squashed three commits into a single commit, so I created a new pull request.
Attachment #8464018 - Attachment is obsolete: true
Attachment #8482173 - Flags: review+
Flags: needinfo?(xfq.free)
that looks good! r=yurenju

merged. 

https://github.com/mozilla-b2g/gaia/commit/8ef1d4c691da54a429bfb9d1f7427c1d0806ad3f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.