1032005 - Fix jshint error for build/download-manager.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #1032004 +++

Comment 1

[Mike Hoye [:mhoye]]

Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2

Comment 2

[Fuqiao Xue [:xfq]]

Attachment: PR on GitHub

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8464018 [details] [review]
PR on GitHub

:xfq,

since we don't use Cr for download-manager.js, could you remove Cr from it? and it will look like:

set me review again if pull request is updated.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

sorry, it will looks like:

> const { Cc, Ci, Cu } = require('chrome');

Comment 5

[Fuqiao Xue [:xfq]]

Comment on attachment 8464018 [details] [review]
PR on GitHub

Done, thanks.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8464018 [details] [review]
PR on GitHub

looks good, please squash to one commit and needinfo? me, I will help to merge it. r=yurenju

Comment 7

[Fuqiao Xue [:xfq]]

Attachment: PRv2 on GitHub

I tried |git rebase -i| but accidentally squashed three commits into a single commit, so I created a new pull request.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

that looks good! r=yurenju

merged. 

https://github.com/mozilla-b2g/gaia/commit/8ef1d4c691da54a429bfb9d1f7427c1d0806ad3f