Closed
Bug 1032032
Opened 11 years ago
Closed 11 years ago
Fix jshint error for build/test/integration/distribution.test.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Unassigned, Mentored)
References
Details
(Whiteboard: [good first bug][mentor-lang=zh])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1032030 +++
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [good first bug][mentor-lang=zh]
|
||
Comment 1•11 years ago
|
||
Some guidance on how to approach this bug is available here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
|
||
Comment 2•11 years ago
|
||
This PR fixes the error. I used the /* - W101 */ for long line because there was no way to shorten the lines
L90, L93, L98, L99
Commit : 686e7c0ea99c2cea0300a70eb4c09ae7ef6c237b
Attachment #8470677 -
Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8470677 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22715
since break those lines to two strings for passing jshint won't enhance readability, I would give r+ for it.
thanks!
Attachment #8470677 -
Flags: review?(yurenju.mozilla) → review+
Flags: needinfo?(yurenju.mozilla)
|
|
Reporter | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•