Fix jshint error for build/test/integration/helper.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: yurenju, Assigned: ShellHacker, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor-lang=zh])

Attachments

(1 attachment, 2 obsolete attachments)

+++ This bug was initially created as a clone of Bug #1032032 +++
Whiteboard: [good first bug][mentor-lang=zh]

Comment 1

4 years ago
Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
(Assignee)

Comment 2

4 years ago
Created attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443
Attachment #8466611 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
Sudheesh, this pull request didn't trigger try-server for testing, could you checkout to your branch, amend your commit without any change and force push again?

commands looks like:

$ git checkout Patch_1032033
$ git commit --amend (just save it without any change)
$ git push origin Patch_1032033 -f

and go to your pull request page, it should appear in few minutes.
Flags: needinfo?(yurenju.mozilla) → needinfo?(sudheesh1995)
Assignee: nobody → sudheesh1995
(Assignee)

Comment 4

4 years ago
The try-server has now been triggered. :)
Flags: needinfo?(sudheesh1995) → needinfo?(yurenju.mozilla)
Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

Sudheesh, since you add 'use strict' into helper.js then we found checkFileContentInZip has been declared twice, could you help to remove the duplicate function?

please set me review flag again if pull request is updated.

thanks!
Attachment #8466611 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
(Assignee)

Comment 6

4 years ago
Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

Duplication removed. Fixed via squashed commit ccf8b5bda149ba8b31e5a71d6c8a166b639f2ea4 on PR 22443
Attachment #8466611 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

catch another issue, we declare an |exec| by |exec = require('child_process').exec;| but also declare another exec function.
Attachment #8466611 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(yurenju.mozilla)
Created attachment 8471301 [details] [diff] [review]
helper.patch

this patch can solve that issue.
(Assignee)

Comment 9

4 years ago
Patched. Added extra commit to fix the merge conflict.
Flags: needinfo?(yurenju.mozilla)
Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

r=yurenju if distribution.test.js and multilocale.test.js are removed in .jshintignore and all commits are squashed to one.

thanks!
Attachment #8466611 - Flags: review+
Flags: needinfo?(yurenju.mozilla)
Created attachment 8472320 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22835

Fixes all problems, The squashing was becoming too much of a problem and too many merge conflicts after updating the branch. So i decided to purge that and redo this. Everything is now in the new pull request that is created. The other one has been closed.

Pull Request : #22835
Commit : 1d7d2ebccd02469f5df9624686a90be2396a7517
Attachment #8466611 - Attachment is obsolete: true
Attachment #8471301 - Attachment is obsolete: true
Attachment #8472320 - Flags: review?(yurenju.mozilla)
Comment on attachment 8472320 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22835

that looks good, thank you!
Attachment #8472320 - Flags: review?(yurenju.mozilla) → review+
merged.

https://github.com/mozilla-b2g/gaia/commit/e91b3d740a90996c492c0a72443cc61eaa741099
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.