1032033 - Fix jshint error for build/test/integration/helper.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #1032032 +++

Comment 1

[Mike Hoye [:mhoye]]

Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2

Comment 2

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22443

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Sudheesh, this pull request didn't trigger try-server for testing, could you checkout to your branch, amend your commit without any change and force push again?

commands looks like:

$ git checkout Patch_1032033
$ git commit --amend (just save it without any change)
$ git push origin Patch_1032033 -f

and go to your pull request page, it should appear in few minutes.

Comment 4

[Sudheesh Singanamalla (:ShellHacker)]

The try-server has now been triggered. :)

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

Sudheesh, since you add 'use strict' into helper.js then we found checkFileContentInZip has been declared twice, could you help to remove the duplicate function?

please set me review flag again if pull request is updated.

thanks!

Comment 6

[Sudheesh Singanamalla (:ShellHacker)]

Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

Duplication removed. Fixed via squashed commit ccf8b5bda149ba8b31e5a71d6c8a166b639f2ea4 on PR 22443

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

catch another issue, we declare an |exec| by |exec = require('child_process').exec;| but also declare another exec function.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: helper.patch

this patch can solve that issue.

Comment 9

[Sudheesh Singanamalla (:ShellHacker)]

Patched. Added extra commit to fix the merge conflict.

Comment 10

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8466611 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22443

r=yurenju if distribution.test.js and multilocale.test.js are removed in .jshintignore and all commits are squashed to one.

thanks!

Comment 11

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22835

Fixes all problems, The squashing was becoming too much of a problem and too many merge conflicts after updating the branch. So i decided to purge that and redo this. Everything is now in the new pull request that is created. The other one has been closed.

Pull Request : #22835
Commit : 1d7d2ebccd02469f5df9624686a90be2396a7517

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8472320 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22835

that looks good, thank you!

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/e91b3d740a90996c492c0a72443cc61eaa741099