1032036 - Fix jshint error for build/test/integration/multilocale.test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #1032033 +++

Comment 1

[Mike Hoye [:mhoye]]

Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2

Comment 2

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22444

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8466612 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22444

Sudheesh, I left some comments on github please check it and there are some suggestion:

1. makeWithMultilocale can be renamed to makeHelper to make this line shorter.
2. some line for |test(description, callback)| is too long, I prefer this style:
>  test('make with relative l10n path but without inline & concat',
>    function(done) {
>      var localesFilePath = path.join(localesDir, 'languages.json');
>      makeHelper(localesFilePath, localesDir, false, done);
>    }
>  );

since this is a simple change, please squash to one commit and force push to your pull request again, here is a link for squash commits https://asciinema.org/a/11269

feel free to needinfo? me if you have any question!

Comment 4

[Sudheesh Singanamalla (:ShellHacker)]

Comment on attachment 8466612 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22444

Fixed this, pushed back a squashed commit.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8466612 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22444

Sudheesh, there are some while space on trail for line 39, 66 and 67 on multilocale.test.js, so r=yurenju if those nits are addressed.

please fix them and needinfo? me again for merging to master.

Comment 6

[Sudheesh Singanamalla (:ShellHacker)]

My text editor doesn't recognize any white space trail on those lines, tried it using vim too for checking in case there were extra trailing spaces. Is there something I am missing there ?

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

still have 4 white spaces on trail of lines, use this command to remove it:

> sed -i 's/[ \t]*$//' build/test/integration/multilocale.test.js

Comment 8

[Sudheesh Singanamalla (:ShellHacker)]

(In reply to Yuren [:yurenju] from comment #7)
> still have 4 white spaces on trail of lines, use this command to remove it:
> 
> > sed -i 's/[ \t]*$//' build/test/integration/multilocale.test.js

sed: 1: "build/test/integration/ ...": undefined label 'uild/test/integration/multilocale.test.js'

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

that command does work on Mac, so this is right one:
> sed -i '' -E "s/[[:space:]]*$//" build/test/integration/multilocale.test.js

Comment 10

[Sudheesh Singanamalla (:ShellHacker)]

(In reply to Yuren [:yurenju] from comment #9)

Fixed now. Thanks. Pushed back onto the same PR 22444

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Sudheesh, last two things:
1. squash two commits to one and
2. modify commit title to "Bug 1032036 - Fix jshint error for build/test/integration/multilocale.test.js r=yurenju"

Comment 12

[Sudheesh Singanamalla (:ShellHacker)]

Squashed and fixed via commit 97a609957a8beb90e7d4ab215035307ad2d0aae6 on PR 22444

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged, thanks!

https://github.com/mozilla-b2g/gaia/commit/a552eb785e92ea46741d2b843a37a54b04318508