1032282 - [Flatfish] [Lockscreen] Hide emergency call button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Joshua Smith [:joshua-s]]

Since the flatfish device does not have cellular capabilities, it is pointless and confusing to have an Emergency Call button on the lockscreen.

Comment 1

[Joshua Smith [:joshua-s]]

This is actually a UX improvement...

Comment 2

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Which is build is this on? Is this on a bug for regular phones?

Comment 3

[Joshua Smith [:joshua-s]]

This is a problem in all the builds I have tested.  To clarify the location of the button: it is on the passcode entry keyboard.

This is not an issue on phones because they have a cellular connection.

Comment 4

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Okay, I can reproduce.

Comment 5

[Anthony Ricaud (:rik)]

I think testing for |if(navigator.mozTelephony)| should be enough. I haven't worked on the tablet though so I hope this API is not available. If it is available, we probably want to file a bug to remove it on systems that can't place a phone call.

Comment 6

[Joshua Smith [:joshua-s]]

Assigning to me!

Comment 7

[Sherman Chen [:chens] (inactive)]

I think this issue is fixed in latest master?

Comment 8

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Putting verifyme keyword in to check to see if this is resolved in latest.

Comment 9

[Sherman Chen [:chens] (inactive)]

Attachment: Lockscreen screenshot

Screenshot on tablet w/ latest gaia

Gaia      cab9e0dd0dee93f31f12313d012e660f074663cf
Gecko     51ac93f62dfaba70de71610bbc14e0b62d7e0525
BuildID   20140714014330
Version   33.0a1

Comment 10

[Joshua Smith [:joshua-s]]

Thank you Sherman!  This issue is actually shown on the pass-code entry field.  To enable this, please go to Settings > Privacy and Security > Screen lock and enable Passcode lock.

Comment 11

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8465257 [details] [review]
Pull request

OK, but please wait for the CI result.

Comment 13

[Anthony Ricaud (:rik)]

Comment on attachment 8465257 [details] [review]
Pull request

This is missing a new test.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

While I indeed miss that check (my fault), my concern is to change another one's review directly is proper or not. What I've experienced is to set f-, not overwrite the existing one.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8465257 [details] [review]
Pull request

To restore the flag as it could be. Maybe I'm wrong, but what I've experienced and heard is we should not change another one's review flag directly. It should come with a f- .

Comment 16

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8465257 [details] [review]
Pull request

PR update and tests added

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8465257 [details] [review]
Pull request

Review+ with nits. Please fix them and make sure CI result is green.

Comment 18

[Sherman Chen [:chens] (inactive)]

Thanks for the comment, PR updated.

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8465257 [details] [review]
Pull request

While I set r+ with nits means you can land the code after you fix the nits.
If you still want to set review to confirm that, you can set review again.

Comment 20

[Sherman Chen [:chens] (inactive)]

Merged to master 
https://github.com/mozilla-b2g/gaia/commit/dde1b44f6e4db389083d1a45ccb495ab40d71bd6

Comment 21

[Sherman Chen [:chens] (inactive)]

Reopen due to tbpl test fail, 
https://github.com/mozilla-b2g/gaia/commit/a14e8e82cbceea9bb3f177aa0441e8461d5232ba

Comment 22

[Sherman Chen [:chens] (inactive)]

Reland on master
https://github.com/mozilla-b2g/gaia/commit/ea45b90fd0dd551d0decdc3e9cc38168ff30185d