Since the flatfish device does not have cellular capabilities, it is pointless and confusing to have an Emergency Call button on the lockscreen.
Which is build is this on? Is this on a bug for regular phones?
This is a problem in all the builds I have tested. To clarify the location of the button: it is on the passcode entry keyboard. This is not an issue on phones because they have a cellular connection.
Okay, I can reproduce.
I think testing for |if(navigator.mozTelephony)| should be enough. I haven't worked on the tablet though so I hope this API is not available. If it is available, we probably want to file a bug to remove it on systems that can't place a phone call.
Assigning to me!
I think this issue is fixed in latest master?
Putting verifyme keyword in to check to see if this is resolved in latest.
Created attachment 8459450 [details] Lockscreen screenshot Screenshot on tablet w/ latest gaia Gaia cab9e0dd0dee93f31f12313d012e660f074663cf Gecko 51ac93f62dfaba70de71610bbc14e0b62d7e0525 BuildID 20140714014330 Version 33.0a1
Thank you Sherman! This issue is actually shown on the pass-code entry field. To enable this, please go to Settings > Privacy and Security > Screen lock and enable Passcode lock.
Created attachment 8465257 [details] [review] Pull request
Comment on attachment 8465257 [details] [review] Pull request OK, but please wait for the CI result.
Comment on attachment 8465257 [details] [review] Pull request This is missing a new test.
While I indeed miss that check (my fault), my concern is to change another one's review directly is proper or not. What I've experienced is to set f-, not overwrite the existing one.
Comment on attachment 8465257 [details] [review] Pull request To restore the flag as it could be. Maybe I'm wrong, but what I've experienced and heard is we should not change another one's review flag directly. It should come with a f- .
Comment on attachment 8465257 [details] [review] Pull request PR update and tests added
Comment on attachment 8465257 [details] [review] Pull request Review+ with nits. Please fix them and make sure CI result is green.
Thanks for the comment, PR updated.
Comment on attachment 8465257 [details] [review] Pull request While I set r+ with nits means you can land the code after you fix the nits. If you still want to set review to confirm that, you can set review again.
Merged to master https://github.com/mozilla-b2g/gaia/commit/dde1b44f6e4db389083d1a45ccb495ab40d71bd6
Reopen due to tbpl test fail, https://github.com/mozilla-b2g/gaia/commit/a14e8e82cbceea9bb3f177aa0441e8461d5232ba
Reland on master https://github.com/mozilla-b2g/gaia/commit/ea45b90fd0dd551d0decdc3e9cc38168ff30185d