1032903 - Erasing the device with SD card as default doesn't erase internal memory

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Marcia Knous [:marcia]]

Flame, while running:

Gaia   90bb898e8401f5fb98edcf38293073c5c26ab7bd
SourceStamp 83c09fe3a658
BuildID 20140701040201
Version 33.0a1

SD Card is the default in this testing, but there is data in both internal memory and on SD card.

STR:
1. With the SD card set as the default, perform an erase command from the FMD website

Expected: Everything on the device gets wiped, including my internal memory
Actual: The internal memory doesn't get wiped.

Comment 1

[Doug Turner (:dougt)]

can we erase the 'apps' type?  that will enumerator /data/.  To do this, we need to have the "webapps-manage" permission.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Good call, Doug. I'll add that to the patch.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Nominated because, unless this is fixed, the remote wipe feature will not work properly, and will only erase some of the device storage.

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 21296

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8449546 [details] [review]
Github PR 21296

Unsetting r? while I respond to review feedback.

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8449546 [details] [review]
Github PR 21296

Hey man,

This needs to be tested again on device, but thought I'd get your feedback anyhow.

I've got the utils ready to be pulled out into a separate file, and I decided to just replace the counter incrementing with Promises-based flow control. I think it looks cleaner.

Mind having a look?

Cheers,

Jared

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I've *finally* got my fix working reliably, thanks to lots of help from dhylands and dougt and ggp.

Hopefully have this merged in the morning.

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Followup bug to refactor the format/erase methods out to a separate utils file: bug 1036019

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

kgrandon reports in #gaia that the marionette failures in the latest try job[1] are not a big deal, merging.

[1] https://tbpl.mozilla.org/?rev=e051b2b181ebd9b5020dfff42c316e1a81de5ab6&tree=Gaia-Try

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/ea3164a2b1e82a40de05ad8393f99d762fb9fe33

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/a623f4fac9b1e4cbba4d9ea61e54c98d15acb470

Comment 15

[Shally Li（leave from Mozilla）]

This issue has been successfully verified on Flame v2.1&2.0.
See attachment: verified_v2.1.mp4.
Reproduce rate: 0/4.

STR:
1. Change "Default media location" to "SD card" on device,
2. Sign in the FMD account on device and PC.
3. Set Lost mode.
**The device into Lost mode.
4. Set Erase.
**Device will restore the factory.
5. Skip FTU and enable USB storage on device.
6. Plug in USB cable.
**Both internal memory and SD card was wiped(deleting all data on internal memory and SD card).

Flame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/ff1100ba2ab8
Build-ID        20141204000228
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.040425
FW-Date         Thu Dec  4 04:04:36 EST 2014
Bootloader      L1TC00011880

Flame 2.1 build:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141204.034958
FW-Date         Thu Dec  4 03:50:09 EST 2014
Bootloader      L1TC00011880

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1.MP4