1033507 - disable tegras on 32 to ride the trains

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

bye bye tegras

Comment 1

[Ed Morley [:emorley]]

Christmas has come early! :-D

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1033507.patch

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: bug1033507builder.diff

builder diff

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: bug1033507builder.diff

Comment 5

[Kim Moir [:kmoir] ET]

As I mentioned before in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1017599#c6

I don't know how to disable talos on a per branch basis until we turn off all Tegra tests.  

Actually now that we have all tests off on certain bramches if I turn off builds on those branches, no talos tests will be invoked.  Let me write a patch for that.

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1033507-2.patch

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: bug1033507builder.diff

builder diff

Comment 8

[Kim Moir [:kmoir] ET]

Callek: I looked at disabling the builds but of course the armv6 apks are still used for 2.3 tests and the android apks are used for 4.0.  So I don't know a good way to disable the associated talos tests for tegras.

If you have suggestions, I'd appreciate them.

See comment #5.

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 8451689 [details] [diff] [review]
bug1033507-2.patch

Review of attachment 8451689 [details] [diff] [review]:
-----------------------------------------------------------------

r- purely because its removing them from aurora as well per the builder diff.

I'd also love a grep of "Tegra" in the full (after) builder list, to verify what branches are left, while we're at it.

To be clear, we *do* want to remove on try, effectively defeating the ability to mobile test beta/etc patches that land?

Comment 10

[Kim Moir [:kmoir] ET]

My understanding is that it's supposed to be removed from the aurora because it will be removed from 32. In the mobile meeting it was mentioned that there would be a lack of test coverage during this change.  The same with try. I have already disabled selected tests on 32 in bug 1017599 which is reflected on Try and m-a.

I'll attach a grep of Tegra in the after builder list.

Comment 11

[Kim Moir [:kmoir] ET]

Attachment: Tegra.jul7

List of builders with Tegra after this change

Comment 12

[Justin Wood (:Callek)]

Comment on attachment 8451689 [details] [diff] [review]
bug1033507-2.patch

Review of attachment 8451689 [details] [diff] [review]:
-----------------------------------------------------------------

Ok then. If be interested in knowing if the b2g* branches still want or need tegra as well

Comment 13

[Kim Moir [:kmoir] ET]

Callek: who should I ask re the b2g branches, not sure if the mobile test meeting is the best place.

Comment 14

[Pete Moore [:pmoore][:pete]]

In production

Comment 15

[Kim Moir [:kmoir] ET]

From #ateam
blassey	go ahead and turn off talos tegras
kmoir	gbrown: I can needinfo blassey on that bug and see if we can disable all talos on tegras
jmaher	blassey++
kmoir	blassey++

So I'll attach a patch to disable all talos testing on tegras

Comment 16

[Justin Wood (:Callek)]

(In reply to Kim Moir [:kmoir] from comment #13)
> Callek: who should I ask re the b2g branches, not sure if the mobile test
> meeting is the best place.

I'm not sure, n-i to :aki to redirect.

For enumeration, kim, which branches are running which tests, with which builds against tegras?

Comment 17

[Aki Sasaki (not active)]

b2g30 has none: https://tbpl.mozilla.org/?tree=Mozilla-B2g30-v1.4
I'm going to follow that pattern for b2g32.

Comment 18

[Kim Moir [:kmoir] ET]

Attachment: bug1033507Talos.patch

patch to disable Talos tests on Tegra across all branches

Comment 19

[Kim Moir [:kmoir] ET]

Attachment: byebyeTegrasTalos

builder diff

Comment 20

[Kim Moir [:kmoir] ET]

Attachment: remainingTegrajobs

List of remaining Tegra jobs after disabling Talos

Comment 21

[Justin Wood (:Callek)]

Comment on attachment 8454595 [details] [diff] [review]
bug1033507Talos.patch

Review of attachment 8454595 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/mobile_config.py
@@ +119,1 @@
>  ANDROID_NOT_PANDA = [slave_plat for slave_plat in ANDROID if 'panda' not in slave_plat]

ANDROID_NOT_PANDA will now be an empty list, followup fodder.

@@ +1658,5 @@
>              if not branch['platforms'][platform][slave_plat]['debug_unittest_suites']:
>                  continue
>              else:
>                  branch['platforms'][platform]['enable_debug_unittests'] = False
> +A

accidental insertion

Comment 22

[Kim Moir [:kmoir] ET]

http://hg.mozilla.org/build/buildbot-configs/rev/45d2362b9356 to disable all Talos tests

Comment 23

[Kim Moir [:kmoir] ET]

verified on tbpl