[B2G][System][Lockscreen]: SIM 1 or SIM 2 not translated for Tamil

VERIFIED FIXED in 2.0 S6 (18july)

Status

VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: mclemmons, Assigned: mnjul)

Tracking

unspecified
2.0 S6 (18july)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v1.4 wontfix, b2g-v2.0 wontfix, b2g-v2.1 verified)

Details

(Whiteboard: LocRun2.0 [p=1] NO_UPLIFT)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
User inserts a SIM in either SIM slot 1 or 2 and enables screen lock within Settings App. After putting the device to sleep and awakening it, the phrase SIM 1 or SIM 2 is not translated for multiple languages. 

Prerequisites:

1. Have SIM in either SIM slot 1 or 2
2. Tap on the "Settings" icon
3. Scroll down to "Privacy & Security" and tap on "Screen lock"
4. Tap on the "Lock screen" toggle to turn it on

Repro Steps:
1) Update a Flame to 20140702000201
2) Tap the "Power/sleep button" on the phone to put the device to sleep and then wake it back up
3) Observe device behavior

Actual:
The phrase SIM 1 or SIM 2 appears not translated

Expected:
The phrase SIM 1 or SIM 2 appears translated 

Environmental Variables:
Device: Flame 2.0
Build ID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: (3/3, 100%)
Link to failed test case: https://moztrap.mozilla.org/manage/case/12107/
See attached: (screenshot – 1 in Tamil)
(Reporter)

Comment 1

5 years ago
The issue described in Comment 0 was confirmed for the following languages: Spanish, Italian, French, Hungarian, and Polish.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
(Reporter)

Comment 2

5 years ago
This issue does reproduce on Flame 2.1 and Flame 1.4 following STR from Comment 0. SIM 1 or SIM 2 is not translated for multiple languages. 

Environmental Variables:
Device: Flame Master
Build ID: 20140702040207
Gaia: 85e97290431ce6aa0a965421e84d6070cd899129
Gecko: 7075808c3306
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Environmental Variables:
Device: Flame 1.4
Build ID: 20140702063007
Gaia: e8599c2b346addf3bf857310502e5b542ae7d0b2
Gecko: 5ff8eb391b65
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

----------------------------------------------------------------------------------------------------

This issue does not reproduce on Buri 2.0 or OpenC 2.1 following STR from Comment 0. SIM 1 or SIM 2 does not display as this device has only 1 SIM slot and only the provider shows above the time (example AT&T). 

Environmental Variables:
Device: Buri 2.0
Build ID: 20140702000201
Gaia: 3bfe47c58c959c42f5ffe0309b5380ea514ccd69
Gecko: f40e767ea283
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C Master
Build ID: 20140625040202
Gaia: 57da30f405ba37a5d4844f32bb292271b81faee2
Gecko: a19e0434ea52
Version: 33.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
(Reporter)

Comment 3

5 years ago
Created attachment 8449664 [details]
SIM screenshot from Tamil
(Reporter)

Comment 4

5 years ago
Created attachment 8449665 [details]
Logcat SIM issue on Lockscreen
(Reporter)

Comment 5

5 years ago
Correction to Comment 0, this case does not fail a specific test case. Exploratory testing was conducted around an existing case to locate this issue.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Delphine - Can you triage this to determine if this is a blocker for l10n?
Flags: needinfo?(lebedel.delphine)
From what I see on Transvision, it seems like Tamil translates the word "SIM". So this is a blocker for Tamil.

However please note that Spanish, Italian, French, Hungarian, and Polish do not translate the word "SIM" (this can be checked on Transvision as well, for example for Spanish: http://transvision.mozfr.org/?recherche=SIM&repo=gaia&sourcelocale=en-US&locale=es&search_type=strings)
blocking-b2g: --- → 2.0?
Flags: needinfo?(lebedel.delphine)
Summary: [B2G][System][Lockscreen]: SIM 1 or SIM 2 not translated for multiple languages → [B2G][System][Lockscreen]: SIM 1 or SIM 2 not translated for Tamil
(In reply to Delphine Lebédel [:delphine - use needinfo] from comment #7)
> From what I see on Transvision, it seems like Tamil translates the word
> "SIM". So this is a blocker for Tamil.

Are you implying this is missing translation and work on the l10n side ? I want to make sure there is no gecko/gaia fix needed here, which is what it looks like and thus won't block here and l10n team can track this. Can you confirm ?
> 
> However please note that Spanish, Italian, French, Hungarian, and Polish do
> not translate the word "SIM" (this can be checked on Transvision as well,
> for example for Spanish:
> http://transvision.mozfr.org/?recherche=SIM&repo=gaia&sourcelocale=en-
> US&locale=es&search_type=strings)
Flags: needinfo?(lebedel.delphine)
No unfortunately this is not just a missing translation. Tamil is one of the rare languages that translates SIM (http://transvision.mozfr.org/string/?entity=apps/system/system.properties:emergencyCallsOnly-noSIM&repo=gaia), which is why we didn't catch this earlier.

Adding Pike here so he can take needed action.
Flags: needinfo?(lebedel.delphine) → needinfo?(l10n)
I'd say it's hard-coded :-\
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/lockscreen_connection_info_manager.js#L198

We have a couple of "SIM {{id}}" strings to reuse for 2.0 in system.properties
Flags: needinfo?(l10n)
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
(In reply to Francesco Lodolo [:flod] from comment #10)
> I'd say it's hard-coded :-\
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/
> lockscreen_connection_info_manager.js#L198
> 
> We have a couple of "SIM {{id}}" strings to reuse for 2.0 in
> system.properties

Triage: +'ing for hardcoded string.

I am actually quite surprised this is found only until now; I don't think this is a 2.0 feature....
Assignee: nobody → jlu
Status: NEW → ASSIGNED
blocking-b2g: 2.0? → 2.0+
It was there even on 1.3, but apparently we didn't ship any locale translating SIM.
But that shouldn't be the case for Tarako, so it just probably slipped through the cracks
https://github.com/mozilla-b2g/gaia/blob/v1.3t/apps/system/js/lockscreen_connection_info_manager.js#L173
Created attachment 8452232 [details] [review]
Patch (PR @ GitHub)

We decided against reusing the old string identifier since the context is quite different, and different translations might be required for some languages. Once the tests passed I will go through review process and other process necessary for adding strings.
(In reply to John Lu [:mnjul] [Out-of-Office 7/11~7/20] from comment #13)
> We decided against reusing the old string identifier since the context is
> quite different, and different translations might be required for some
> languages. Once the tests passed I will go through review process and other
> process necessary for adding strings.

For 2.1 you're free to add a new string (that's what I'd suggest), that's not possible on 2.0, and that's why I suggested to reuse an existing string.
(In reply to Francesco Lodolo [:flod] from comment #14)
> (In reply to John Lu [:mnjul] [Out-of-Office 7/11~7/20] from comment #13)
> > We decided against reusing the old string identifier since the context is
> > quite different, and different translations might be required for some
> > languages. Once the tests passed I will go through review process and other
> > process necessary for adding strings.
> 
> For 2.1 you're free to add a new string (that's what I'd suggest), that's
> not possible on 2.0, and that's why I suggested to reuse an existing string.

Yeeeap, that makes sense. Maybe for the 2.0 uplift patch I shall reuse the existing identifier. Tim, how do you think? Thanks.
Flags: needinfo?(timdream)
(In reply to John Lu [:mnjul] [Out-of-Office 7/11~7/20] from comment #15)
> Yeeeap, that makes sense. Maybe for the 2.0 uplift patch I shall reuse the
> existing identifier. Tim, how do you think? Thanks.

Sounds good. That's more work for you unfortunately (to provide branch-specific patch).
Flags: needinfo?(timdream)
Comment on attachment 8452232 [details] [review]
Patch (PR @ GitHub)

Hi Arthur,

Judging from the change history of the changed file, I guess it's you to review this small patch for me? Thanks.
Attachment #8452232 - Attachment description: WIP Patch (PR @ GitHub) → Patch (PR @ GitHub)
Attachment #8452232 - Flags: review?(arthur.chen)
[re: reuse string in 2.0]

I've just realized there is no available string to reuse in 2.0 -- There is no such string as SIM {{xxx}} in 2.0's system.properties string pool: https://github.com/mozilla-b2g/gaia/blob/v2.0/apps/system/locales/system.en-US.properties . What we're seeing in master https://github.com/mozilla-b2g/gaia/blob/master/apps/system/locales/system.en-US.properties#L524 (lines 524 and 530) was added in bug 1016368, which was after v2.0 merge cutoff and was not uplifted to v2.0 either.

flod, what does the localization team think about this? Shall we break string freeze for 2.0?
Whiteboard: LocRun2.0 → LocRun2.0 [p=1]
Target Milestone: --- → 2.0 S6 (18july)
Ouch, I didn't remember these strings being so recent :-\

The decision to eventually break string freeze is actually up to release drivers. Having said that, I'd be personally fine with having this hard-coded on 2.0, considering that it's been like this since 1.3 and nobody noticed.

Also looking at this link, this affects a minority of locales (15/52), mostly Indic
http://transvision.mozfr.org/string/?entity=apps/ftu/ftu.properties:simDetail&repo=gaia
Comment on attachment 8452232 [details] [review]
Patch (PR @ GitHub)

Looks good to me, thanks John!
Attachment #8452232 - Flags: review?(arthur.chen) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/990bb2c47c6484c8b2d7e78ac77e9e2f61214e60

Per offline discussion with Tim, we will not break string freeze for 2.0.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
status-b2g-v2.0: affected → wontfix
Howie, could you check if I have properly set project management-related flags? Thanks a lot!
status-b2g-v2.0: wontfix → affected
status-b2g-v2.1: affected → fixed
(In reply to Francesco Lodolo [:flod] from comment #19)
> Ouch, I didn't remember these strings being so recent :-\
> 
> The decision to eventually break string freeze is actually up to release
> drivers. Having said that, I'd be personally fine with having this
> hard-coded on 2.0, considering that it's been like this since 1.3 and nobody
> noticed.
> 
> Also looking at this link, this affects a minority of locales (15/52),
> mostly Indic
> http://transvision.mozfr.org/string/?entity=apps/ftu/ftu.properties:
> simDetail&repo=gaia

We need to discuss this more - I don't want us ending up in a situation where a partner cert blocks us late down the line because they expected a translation here. When Delphine originally analyzed this bug, she indicated it was a blocker for Tamil.
Whiteboard: LocRun2.0 [p=1] → LocRun2.0 [p=1] NO_UPLIFT
status-b2g-v1.4: affected → wontfix
Is this wontfix for 2.0 at this point?
Flags: needinfo?(jlu)
Uh...Let me ask my EPM. Howie, what's the standard procedure here (or we need to flag in a product manager)? Thanks.
Flags: needinfo?(jlu) → needinfo?(hochang)

Comment 26

5 years ago
offline discussed with Bruce, won't fix in 2.0. If a partner wants to block on this one cert they can cherry pick the patch. Thanks.
status-b2g-v2.0: affected → wontfix
Flags: needinfo?(hochang)
Depends on: 1085496
This issue is verified on Flame 2.1.

Result: "SIM" string is translated in Tamil.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029001202
Gaia: eb0aab0f13c78c7ac378ad860e865c4b6eaf669f
Gecko: 318019f80a8e
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][lead-review+] → [QAnalyst-Triage?][lead-review+]
status-b2g-v2.1: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?][lead-review+] → [QAnalyst-Triage+][lead-review+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.