show scroll bar should be set to Always on 10.10 test slaves

RESOLVED FIXED

Status

Release Engineering
Platform Support
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kmoir, Assigned: kmoir)

Tracking

(Blocks: 4 bugs)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2130] )

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
spohl is working on greening up the 10.9 test slaves and ran into this issue which we debugged today where scrollbars tests fail on 10.9 but not 10.8 and 10.7

	spohl	oh, I think I just found the answer to our questions
	spohl	10.9 changed the way headless mac minis are treated when it comes to scrollbars
	spohl	https://discussions.apple.com/thread/5467890
	spohl	as I guessed, they now show overlay scrollbars when no mouse is attached
	spohl	so… it sounds like those slaves will need to have that pref set manually in system preferences…
	kmoir	okay it should be set to always?
        spohl	yes, I'm afraid so.

So we'll need to change this in the 10.9 puppet config.  The defaults setting is  AppleShowScrollBars = Always;  You just need to defaults write this in the puppet config.
See bug 1009726, comment 15.
(Assignee)

Comment 2

3 years ago
Ah. So closing this request then.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Reopening based on bug 1009726 comment 18.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Blocks: 1035274
Kim, just letting you know that we've reopened this bug and we'll need this change. Thanks!
Flags: needinfo?(kmoir)
(Assignee)

Comment 5

3 years ago
yes, I'm going to do this I just have to fix another bug first
Flags: needinfo?(kmoir)

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2121]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2121] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2130]
(Assignee)

Updated

3 years ago
Summary: show scroll bar should be set to Always on 10.9 test slaves → show scroll bar should be set to Always on 10.10 test slaves
(Assignee)

Comment 6

3 years ago
Created attachment 8533973 [details] [diff] [review]
bug1033650.patch

I didn't test this in staging because the only machine available was attached to your staging environment. I did test the command via the command line and it changed the pref
Attachment #8533973 - Flags: review?(coop)

Updated

3 years ago
Attachment #8533973 - Flags: review?(coop) → review+
(Assignee)

Comment 7

3 years ago
Comment on attachment 8533973 [details] [diff] [review]
bug1033650.patch

and merged to production
Attachment #8533973 - Flags: checked-in+
(Assignee)

Comment 8

3 years ago
verified 10.10 slaves have scrollbars enabled to always
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Thank you, Kim!
Blocks: 1121505
Blocks: 1121480
(Assignee)

Updated

3 years ago
Assignee: nobody → kmoir
(Assignee)

Comment 10

3 years ago
Comment on attachment 8533973 [details] [diff] [review]
bug1033650.patch

I've reverted this patch.  The yosemite slaves are in a weird state re this plist. It doesn't let me change it via the ui, although the underlying plist says the preference is set.  I removed it so I could reimage a machine and test it without this being a factor.
Attachment #8533973 - Flags: checked-in+ → checked-in-
(Assignee)

Updated

3 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 11

3 years ago
Created attachment 8552119 [details] [diff] [review]
bug1033650-2.patch

Better patch which I tested in staging. The problem was that the plist was owned after root after puppet ran which meant cltbld couldn't read it.
Attachment #8533973 - Attachment is obsolete: true
Attachment #8552119 - Flags: review?(coop)
Comment on attachment 8552119 [details] [diff] [review]
bug1033650-2.patch

Review of attachment 8552119 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/gui/manifests/appearance.pp
@@ +24,5 @@
>                          group => "$users::root::group",
>                          mode => 0755,
>                          notify => Exec["set-background-image"] ;
>                  }
> +            }     

Just a nit: cleanup the whitespace before landing.
Attachment #8552119 - Flags: review?(coop) → review+
(Assignee)

Comment 13

3 years ago
Comment on attachment 8552119 [details] [diff] [review]
bug1033650-2.patch

whitespace fixed, patch landed and merged to production
Attachment #8552119 - Flags: checked-in+
(Assignee)

Comment 14

3 years ago
verified that this is fixed now with current test runs
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.