1033650 - show scroll bar should be set to Always on 10.10 test slaves

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

spohl is working on greening up the 10.9 test slaves and ran into this issue which we debugged today where scrollbars tests fail on 10.9 but not 10.8 and 10.7

	spohl	oh, I think I just found the answer to our questions
	spohl	10.9 changed the way headless mac minis are treated when it comes to scrollbars
	spohl	https://discussions.apple.com/thread/5467890
	spohl	as I guessed, they now show overlay scrollbars when no mouse is attached
	spohl	so… it sounds like those slaves will need to have that pref set manually in system preferences…
	kmoir	okay it should be set to always?
        spohl	yes, I'm afraid so.

So we'll need to change this in the 10.9 puppet config.  The defaults setting is  AppleShowScrollBars = Always;  You just need to defaults write this in the puppet config.

Comment 1

[Timothy Nikkel (:tnikkel)]

See bug 1009726, comment 15.

Comment 2

[Kim Moir [:kmoir] ET]

Ah. So closing this request then.

Comment 3

[Stephen A Pohl [:spohl]]

Reopening based on bug 1009726 comment 18.

Comment 4

[Stephen A Pohl [:spohl]]

Kim, just letting you know that we've reopened this bug and we'll need this change. Thanks!

Comment 5

[Kim Moir [:kmoir] ET]

yes, I'm going to do this I just have to fix another bug first

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1033650.patch

I didn't test this in staging because the only machine available was attached to your staging environment. I did test the command via the command line and it changed the pref

Comment 7

[Kim Moir [:kmoir] ET]

Comment on attachment 8533973 [details] [diff] [review]
bug1033650.patch

and merged to production

Comment 8

[Kim Moir [:kmoir] ET]

verified 10.10 slaves have scrollbars enabled to always

Comment 9

[Stephen A Pohl [:spohl]]

Thank you, Kim!

Comment 10

[Kim Moir [:kmoir] ET]

Comment on attachment 8533973 [details] [diff] [review]
bug1033650.patch

I've reverted this patch.  The yosemite slaves are in a weird state re this plist. It doesn't let me change it via the ui, although the underlying plist says the preference is set.  I removed it so I could reimage a machine and test it without this being a factor.

Comment 11

[Kim Moir [:kmoir] ET]

Attachment: bug1033650-2.patch

Better patch which I tested in staging. The problem was that the plist was owned after root after puppet ran which meant cltbld couldn't read it.

Comment 12

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8552119 [details] [diff] [review]
bug1033650-2.patch

Review of attachment 8552119 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/gui/manifests/appearance.pp
@@ +24,5 @@
>                          group => "$users::root::group",
>                          mode => 0755,
>                          notify => Exec["set-background-image"] ;
>                  }
> +            }     

Just a nit: cleanup the whitespace before landing.

Comment 13

[Kim Moir [:kmoir] ET]

Comment on attachment 8552119 [details] [diff] [review]
bug1033650-2.patch

whitespace fixed, patch landed and merged to production

Comment 14

[Kim Moir [:kmoir] ET]

verified that this is fixed now with current test runs