Closed Bug 1033838 Opened 11 years ago Closed 10 years ago

enable tab tests with an e10s addon

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(e10s+)

Status:
RESOLVED FIXED
Milestone:
mozilla37
Tracking Flags:
Tracking Status
e10s + ---

People

(Reporter: zombie, Assigned: zombie)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1537
46 bytes, text/x-github-pull-request
mossop
: review+
irakli
: feedback+
Details | Review
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1561
46 bytes, text/x-github-pull-request
Details | Review
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1784
46 bytes, text/x-github-pull-request
mossop
: review+
Details | Review
bug 1004833 enables us to make test addons run in e10s mode. bug 1023326 has now landed (along with some other fixed bugs), so a significant portion of the tab tests should pass in e10s mode.
this is four (smaller) test-tab-*.js files copied, with a single (last) line commented-out, all included in a test addon that has the e10s flag set.
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Attachment #8449882 - Flags: review?(dtownsend+bugmail)
Attachment #8449882 - Flags: feedback?(rFobic)
Attachment #8449882 - Flags: review?(dtownsend+bugmail) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/dd6875e1f46b248968e83decb72506d1a0fd4535 bug 1033838 - enable tab tests with e10s https://github.com/mozilla/addon-sdk/commit/578231d3f840a4779431da73176e4308f0a8d7e4 Merge pull request #1537 from zombie/1033838-tab-tests bug 1033838 - enable tab tests with e10s, r=@Mossop
Comment on attachment 8449882 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1537 Land land land!
Attachment #8449882 - Flags: feedback?(rFobic) → feedback+
Depends on: 1049189
Depends on: 1054482
Attachment #8542661 - Flags: review?(dtownsend) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/84120f0e1f1af8f23d225f817a3e7627cae594ba bug 1033838 - fix test-tab.js and eable it in e10s test addon https://github.com/mozilla/addon-sdk/commit/6cf26242a1207bf7c6f699b1f28469402cf83d82 Merge pull request #1784 from zombie/1033838-fix-test-tab bug 1033838 - fix test-tab.js and eable it in e10s test addon, r=@Mossop
Depends on: 1116834
Blocks: e10s-sdk
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: