1034270 - bug 989875 and bug 1025332 conflicted and broke opening the certificate exception dialog

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Looks like the patches from bug 989875 and bug 1025332 conflicted and broke opening the certificate exception dialog. Sad to say, we have no tests that caught this.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: fix

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: test

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to David Keeler (:keeler) [use needinfo?] from comment #0)
> Looks like the patches from bug 989875 and bug 1025332 conflicted and broke
> opening the certificate exception dialog. Sad to say, we have no tests that
> caught this.

Well, we have Mozmill tests and we also caught this today. See bug 1034581. But it would be good to also have an in-tree automated test.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Here's a try run: https://tbpl.mozilla.org/?tree=Try&rev=31ee012cdac5

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/a84c5a1faa1c
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd59434cdb02

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a84c5a1faa1c
https://hg.mozilla.org/mozilla-central/rev/fd59434cdb02