Closed Bug 1034270 Opened 7 years ago Closed 7 years ago

bug 989875 and bug 1025332 conflicted and broke opening the certificate exception dialog

Categories

(Core Graveyard :: Security: UI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: keeler, Assigned: keeler)

References

Details

Attachments

(2 files)

Looks like the patches from bug 989875 and bug 1025332 conflicted and broke opening the certificate exception dialog. Sad to say, we have no tests that caught this.
Attached patch fixSplinter Review
Attachment #8450502 - Flags: review?(felipc)
Attached patch testSplinter Review
Attachment #8450503 - Flags: review?(felipc)
(In reply to David Keeler (:keeler) [use needinfo?] from comment #0)
> Looks like the patches from bug 989875 and bug 1025332 conflicted and broke
> opening the certificate exception dialog. Sad to say, we have no tests that
> caught this.

Well, we have Mozmill tests and we also caught this today. See bug 1034581. But it would be good to also have an in-tree automated test.
Flags: in-testsuite?
Blocks: 1034203
Duplicate of this bug: 1035064
Attachment #8450502 - Flags: review?(felipc) → review+
Attachment #8450503 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/a84c5a1faa1c
https://hg.mozilla.org/mozilla-central/rev/fd59434cdb02
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Duplicate of this bug: 1035632
Duplicate of this bug: 1036035
Duplicate of this bug: 1036265
Flags: in-testsuite? → in-testsuite+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.