1034404 - Get rid of the Thebes backed gfxContexts in ThebesLayerD3D9

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

Assuming no problems come up, the ThebesLayerD3D9 code will be removed after the next uplift (bug 1031089). The two Thebes backed gfxContexts there are all that stand between us and killing off Thebes backed gfxContext completely though. Since it's trivial to kill that code I'd like to do that.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8450719 [details] [diff] [review]
patch

Review of attachment 8450719 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +1025,5 @@
> +  } else {
> +    bounds = nsIntRect(nsIntPoint(0, 0), aSurface->GetSize());
> +  }
> +  cairo_rectangle(ctx, bounds.x, bounds.y, bounds.width, bounds.height);
> +  cairo_fill(ctx);

This is a little iffy, CAIRO_OPERATOR_SOURCE has different semantics from clear I think. But this probably will be fine in all use-cases. Please do a reftest run without OMTC to verify this doesn't break on our WinXP buildbots.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a63018c83a5

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a63018c83a5