1034581 - Test failure 'Modal dialog has been found and processed' in /testSecurity/testMD5HashSignature.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

Module:    testMD5HashSignature
Test:      /testSecurity/testMD5HashSignature.js    
Failure:   Modal dialog has been found and processed
Branches:  default
Platforms: All
Report:    http://mozmill-daily.blargon7.com/#/remote/report/8e52cc909fb28910195c4e255e595294

Reproducible cross platform.

Comment 1

[Andrei Eftimie]

Attachment: skip.patch

Henrik please review, we need to disable this test.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8450943 [details] [diff] [review]
skip.patch

Review of attachment 8450943 [details] [diff] [review]:
-----------------------------------------------------------------

The change in the manifest should be enough those days given that we no longer use mozmill 1.5.x, but the skip looks fine. Sad to see that we have to skip it again. Do you already know what caused this regression?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Andrei, please give at least the pushlog for the builds since it has been started. That should become a default action when filing P1 regression bugs.

Comment 4

[Andrei Eftimie]

Comment on attachment 8450943 [details] [diff] [review]
skip.patch

Review of attachment 8450943 [details] [diff] [review]:
-----------------------------------------------------------------

Disabled:
https://hg.mozilla.org/qa/mozmill-tests/rev/0b4aba67fb19 (default)

> The change in the manifest should be enough those days given that we no longer use mozmill 1.5.x, but the skip looks fine.
True, but we haven't yet decided we should only skip via manifest files. If we do that we might also take out the skips from all testfiles themselves to be consistent.

> Sad to see that we have to skip it again. Do you already know what caused this regression?
Not yet, looking into that atm

Comment 5

[Andrei Eftimie]

I can reproduce it manually.

Steps:
1) Visit http://mozqa.com/data/firefox/security/certificates/md5/importSSL.php and import the certificate
2) Visit https://ssl-md5.mozqa.com/ and click on "I understand the Risks" > "Add Exception"

Expected result: A modal dialog opens where you can "Confirm Security Exception"
Actual result: Nothing happens

Comment 6

[Andrei Eftimie]

Pushlog on mc (pretty big, several merges from fx-team and inbound):
https://hg.mozilla.org/mozilla-central/pushloghtml?tochange=e8df6826a571&fromchange=38ecfc3922b8

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not sure, but bug 940506 may be an option. I assume David would know more what landed recently and could have caused this problem.

Comment 8

[Andrei Eftimie]

Well, on inbound the regressor came from mc:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=94f150f5b21f&tochange=1022c98a62d2

And on fx-team I have a really strange pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2a523e4ae004&tochange=37ba46f2c7c2
(which doesn't make any sense to me... seems tinderbox builds on fx-team are not done on commit anymore..)

Bug 940506 is not in the mc > inbound merge, so it might be something else.

Comment 9

[Andrei Eftimie]

This is probably it bug 989875

Comment 10

[Andrei Eftimie]

Seems the "Add Exception" button was broken for e10s windows. With the fix for that it is now broken for normal windows.

Jim could you please look into this?

Comment 11

[Dana Keeler (she/her) (use needinfo) [:keeler]]

I think there was a merge conflict. See bug 1034270.

Comment 12

[Andrei Eftimie]

Backed out skip on Nightly:
https://hg.mozilla.org/qa/mozmill-tests/rev/3e680693ef23 (default)

On Aurora the test still needs to remain disabled because of bug 1041420
(the fix for this already got uplift approval for Aurora, we should check in 1-2 days back again)

Comment 13

[Andrei Eftimie]

Setting a flag so I'll remember to check back.

Comment 14

[Andrei Eftimie]

All works fine on Aurora now, transplanted:
https://hg.mozilla.org/qa/mozmill-tests/rev/b16e0a13a3fb (mozilla-aurora)