Closed Bug 1035101 Opened 10 years ago Closed 10 years ago

H264 HTML5 videos appears black/blank on Youtube and others in 2014-07-07 nightly

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
33 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla33
Tracking Flags:
Tracking Status
firefox33 - affected

People

(Reporter: alice0775, Assigned: nical)

References

Details

(Keywords: regression)

Attachments

(1 file)

Don't fail when a shared D3D texture doesn't have a mutex.
1.56 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
Steps To Reproduce:
1. http://ie.microsoft.com/testdrive/Graphics/VideoFormatSupport/Default.html and play back
   http://www.bucksch.org/xfer/walter-roehrl-short.mp4

Actual Results:
  Some HTML5 video is black


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/22524cb2d69f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140704012119
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fb0089cfb28
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140704012717
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=22524cb2d69f&tochange=3fb0089cfb28

Regressed by:
3fb0089cfb28	Nicolas Silva — Bug 1019000 - Ensure that successfully write-locked D3D TextureClients provide a valid DrawTarget. r=mattwoodrow
I will look into this. We can back out the patch that caused the issue, but I want to understand what is going on. This problem seems to indicate that we were passing textures to the compositor without successfully locking them which sounds like trouble.
Assignee: nobody → nical.bugzilla
This happens on h264 video only from what I can tell. WebM and Ogg video are played back correctly. Using https://videos.cdn.mozilla.net/uploads/mozillaorg/ as a test set.
(In reply to Kevin Brosnan [:kbrosnan] from comment #3)
> This happens on h264 video only from what I can tell. WebM and Ogg video are
> played back correctly. Using
> https://videos.cdn.mozilla.net/uploads/mozillaorg/ as a test set.

Confirmed and toggling media.windows-media-foundation.use-dxva to false makes h264 work for me.
Shouldn't the if (!mutex) branch in LockD3DTexture return true? Textures created by the DXVA decoders don't have a mutex for synchronization, so we should just assume they're fine rather than not rendering them at all.
(In reply to Matt Woodrow (:mattwoodrow) from comment #5)
> Shouldn't the if (!mutex) branch in LockD3DTexture return true? Textures
> created by the DXVA decoders don't have a mutex for synchronization, so we
> should just assume they're fine rather than not rendering them at all.

Good to know. I'll  write a quick patch to return tru in the !mutex branch.
Attachment #8452252 - Flags: review?(matt.woodrow) → review+
Making summary more keyword rich, based on duped bugs.
Summary: Some HTML5 video is black → H264 HTML5 videos appears black/blank on Youtube and others in 2014-07-07 nightly
Just tested the m-i build with this patch and for some reason FlashBlock is no longer blocking as it should.
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #13)
> Just tested the m-i build with this patch and for some reason FlashBlock is
> no longer blocking as it should.

Nevermind, Flashblock was broken by https://bugzilla.mozilla.org/show_bug.cgi?id=1027601, working after patch was backed out on m-i, and HTML5 / Vimeo working fine with this patch.

Sorry for noise.
Is this bug why https://www.youtube.com/watch?v=3dldN-sqIZM&html5=true plays only audio on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140709030201 CSet: 196d05832e12 ?
https://hg.mozilla.org/mozilla-central/rev/6292743f667f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Tested with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 ID:20140710030200 CSet: cb75d6cfb004 and all the video links on this bug now work.

Thanks!
Status: RESOLVED → VERIFIED
It seems that a similar bug affects B2G 1.3 since begin of july. But it affects all types of videos. See: http://forum.geeksphone.com/index.php?topic=6201.0

Is it possible that this regression could appear via the patches of Firefox OS?
I'm having this problem on Youtube in Nightly 32.0a2 32-bit for 64-bit Windows 7. It's worth noting that audio still plays, and when using the "tab scope" add-on to preview a tab with a playing Youtube video the video does indeed render in the preview.
(In reply to judilsteve from comment #19)
> I'm having this problem on Youtube in Nightly 32.0a2 32-bit for 64-bit
> Windows 7. It's worth noting that audio still plays, and when using the "tab
> scope" add-on to preview a tab with a playing Youtube video the video does
> indeed render in the preview.

WFM.  Have you tried safe mode?  Is this on a range of dates or is it a specific build?  Are you running Greasemonkey?  Something changed, and now one of my scripts needed to be disabled to get YouTube working correctly.
(In reply to Bryan Price from comment #20)
> (In reply to judilsteve from comment #19)
> > I'm having this problem on Youtube in Nightly 32.0a2 32-bit for 64-bit
> > Windows 7. It's worth noting that audio still plays, and when using the "tab
> > scope" add-on to preview a tab with a playing Youtube video the video does
> > indeed render in the preview.
> 
> WFM.  Have you tried safe mode?  Is this on a range of dates or is it a
> specific build?  Are you running Greasemonkey?  Something changed, and now
> one of my scripts needed to be disabled to get YouTube working correctly.

This has been happening for about a week now, so not just a specific build (if the name Nightly rings true). I am running greasemonkey, but after disabling it the problem persists. However restarting in safe mode allows the videos to render fine, so it must be one of my other addons, or a combination of them, of which there are many. I will try disabling them one by one until I can narrow down the addon or combination of addons causing it, but it may take a while as I use all of the following:

Adblock Plus 2.6.3
Advanced Cookie Manager 5.7
BetterPrivacy 1.68
BYTubeD 1.1.2a2
Classic Theme Restorer 1.2.2
DownThemAll! 2.0.17
FlashGot 1.5.6.2
Ghostery 5.3.2
HTTPS Finder 0.91
HTTPS-Everywhere 3.5.3
Imgur Uploader 1.0.6
Media Loop 0.2.3
Private Tab 0.1.7.3pre2
Reddit Enhancement Suite 4.3.2.1 (that's really the version number)
Screenshoter Fixed 1.0.8
Tab Mix Plus 0.4.1.4
Tab Scope 1.5
Toolbar Autohide 6.5.11
Greasemonkey 2.0
(In reply to judilsteve from comment #21)
> (In reply to Bryan Price from comment #20)
> > (In reply to judilsteve from comment #19)
> > > I'm having this problem on Youtube in Nightly 32.0a2 32-bit for 64-bit
> > > Windows 7. It's worth noting that audio still plays, and when using the "tab
> > > scope" add-on to preview a tab with a playing Youtube video the video does
> > > indeed render in the preview.
> > 
> > WFM.  Have you tried safe mode?  Is this on a range of dates or is it a
> > specific build?  Are you running Greasemonkey?  Something changed, and now
> > one of my scripts needed to be disabled to get YouTube working correctly.
> 
> This has been happening for about a week now, so not just a specific build
> (if the name Nightly rings true). I am running greasemonkey, but after
> disabling it the problem persists. However restarting in safe mode allows
> the videos to render fine, so it must be one of my other addons, or a
> combination of them, of which there are many. I will try disabling them one
> by one until I can narrow down the addon or combination of addons causing
> it, but it may take a while as I use all of the following:
> 
> Adblock Plus 2.6.3
> Advanced Cookie Manager 5.7
> BetterPrivacy 1.68
> BYTubeD 1.1.2a2
> Classic Theme Restorer 1.2.2
> DownThemAll! 2.0.17
> FlashGot 1.5.6.2
> Ghostery 5.3.2
> HTTPS Finder 0.91
> HTTPS-Everywhere 3.5.3
> Imgur Uploader 1.0.6
> Media Loop 0.2.3
> Private Tab 0.1.7.3pre2
> Reddit Enhancement Suite 4.3.2.1 (that's really the version number)
> Screenshoter Fixed 1.0.8
> Tab Mix Plus 0.4.1.4
> Tab Scope 1.5
> Toolbar Autohide 6.5.11
> Greasemonkey 2.0

Scratch that, the bug seems to have been fixed in the latest build.
This bug affect 1.3 also, please, could you fix it?
Please file a new bug this was a bug in Firefox OS. Firefox nightly 33 has nothing to do with FxOS 1.3.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: