Closed
Bug 1035279
Opened 11 years ago
Closed 11 years ago
[Messages][Refactoring] Move error codes mapping from dialog.js to a separate file
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: azasypkin, Assigned: azasypkin)
References
Details
(Whiteboard: [sms-sprint-2.0S6][p=1])
Attachments
(1 file)
*** Follow-up from bug 990020 ***
We need to extract the error information into its own file + lazily fill error map object.
|
Assignee | |
Comment 1•11 years ago
|
||
Hey Julien,
Could you please review this refactoring patch?
Thanks!
Attachment #8453021 -
Flags: review?(felash)
|
|
Assignee | |
Updated•11 years ago
|
Blocks: sms-sprint-2.0S6, 990021
Whiteboard: [not-part-of-initial-sprint]
Target Milestone: --- → 2.0 S6 (18july)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8453021 [details] [review]
GitHub pull request URL
I like this a lot more, but I still don't like the constant... What do you think of my string namespacing approach?
Attachment #8453021 -
Flags: review?(felash)
|
|
||
Updated•11 years ago
|
Flags: needinfo?(felash)
|
|
||
Updated•11 years ago
|
Flags: needinfo?(felash)
Whiteboard: [not-part-of-initial-sprint] → [sms-sprint-2.0S6][p=1]
Target Milestone: 2.0 S6 (18july) → 2.1 S1 (1aug)
|
|
||
Updated•11 years ago
|
Flags: needinfo?(felash)
|
|
||
Comment 3•11 years ago
|
||
As discussed on IRC, we'll get rid of the enum until it proves useful.
Thanks !
Flags: needinfo?(felash)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8453021 [details] [review]
GitHub pull request URL
(In reply to Julien Wajsberg [:julienw] from comment #3)
> As discussed on IRC, we'll get rid of the enum until it proves useful.
> Thanks !
Done in a separate commit, thanks!
Attachment #8453021 -
Flags: review?(felash)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8453021 [details] [review]
GitHub pull request URL
r=me
I tried various error cases and it looks to work fine.
One nit for the jshint directive but that's all.
Thanks !
Attachment #8453021 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #5)
> Comment on attachment 8453021 [details] [review]
> GitHub pull request URL
>
> r=me
>
> I tried various error cases and it looks to work fine.
> One nit for the jshint directive but that's all.
>
> Thanks !
Fixed nit and landed, thanks!
Master: https://github.com/mozilla-b2g/gaia/commit/7198320c257340009a6d6d0e12e609058881d230
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•