1035279 - [Messages][Refactoring] Move error codes mapping from dialog.js to a separate file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

*** Follow-up from bug 990020 ***

We need to extract the error information into its own file + lazily fill error map object.

Comment 1

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hey Julien,

Could you please review this refactoring patch?

Thanks!

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Comment on attachment 8453021 [details] [review]
GitHub pull request URL

I like this a lot more, but I still don't like the constant... What do you think of my string namespacing approach?

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

As discussed on IRC, we'll get rid of the enum until it proves useful.
Thanks !

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8453021 [details] [review]
GitHub pull request URL

(In reply to Julien Wajsberg [:julienw] from comment #3)
> As discussed on IRC, we'll get rid of the enum until it proves useful.
> Thanks !

Done in a separate commit, thanks!

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Comment on attachment 8453021 [details] [review]
GitHub pull request URL

r=me

I tried various error cases and it looks to work fine.
One nit for the jshint directive but that's all.

Thanks !

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #5)
> Comment on attachment 8453021 [details] [review]
> GitHub pull request URL
> 
> r=me
> 
> I tried various error cases and it looks to work fine.
> One nit for the jshint directive but that's all.
> 
> Thanks !

Fixed nit and landed, thanks!

Master: https://github.com/mozilla-b2g/gaia/commit/7198320c257340009a6d6d0e12e609058881d230