990020 - [B2G][SMS] A MMS that has not been downloaded yet will display a "Missing SIM card" message after changing the SIM to a different valid one

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

We need to handle the "SimNotMatchedError" error when retrieving a message.

See below for the initial description. Currently, the displayed message will be the generic error message which is not very good because the generic message is more suited when sending a message.

+++ This bug was initially created as a clone of Bug #981077 +++

Description:
When there is an MMS attachment pending if the user switches the SIM card and tries to then download the MMS attachment the message "Missing SIM card" appears even though the new SIM card can be used. Essentially the message is inappropriate for the situation.

Repro Steps:
1) Update a Buri to BuildID: 20140307040203
2) Go to Settings -> Messaging settings and turn Auto retrieve OFF.
3) Send an MMS from another device to the test device.
4) Open the message app to view the message, but do not download the attachment.
5) Power down the test device and change to another valid SIM.
6) Power back on the device and go to the message app.
7) Attempt to download the MMS attachment.

Actual:
The message "Missing SIM card" appears

Expected:
A message properly explaining why the attachment cannot be downloaded is displayed.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140307040203
Gaia: 04eb7996543f114133d1367f834a4d88b68c60ac
Gecko: b0e7f63c2138
Version: 30.0a1
Firmware Version: v1.2-device.cfg


Keywords: SMS


Notes: Likely related to https://bugzilla.mozilla.org/show_bug.cgi?id=924178


Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/8275/
See attached: screenshot of message

Comment 1

[Julien Wajsberg [:julienw]]

NI Joe because we need to prioritize this in the 1.5 time frame.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

already 1.5?, this will be triaged during comms team triage
Thanks

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

triage: add to 1.5 targetted list

Comment 4

[Oleg Zasypkin [:azasypkin]]

Hey Jenny,

I'm not sure whether you're right person to ask about it :), but could you please advise what title and text should be used for the error dialog explaining that the attachment cannot be downloaded because of the SIM mismatch?

Thanks!

Comment 5

[Jenny Lee]

(In reply to Oleg Zasypkin [:azasypkin] from comment #4)
> Hey Jenny,
> 
> I'm not sure whether you're right person to ask about it :), but could you
> please advise what title and text should be used for the error dialog
> explaining that the attachment cannot be downloaded because of the SIM
> mismatch?
> 
> Thanks!

Hello Oleg :D 
There should be a professional tech writer to help on this. But here's my suggestion:
"Unable to download. Please make sure the SIM card inserted is the one when this message was received."
Thanks!

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to Jenny Lee from comment #5)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #4)
> > Hey Jenny,
> > 
> > I'm not sure whether you're right person to ask about it :), but could you
> > please advise what title and text should be used for the error dialog
> > explaining that the attachment cannot be downloaded because of the SIM
> > mismatch?
> > 
> > Thanks!
> 
> Hello Oleg :D 
> There should be a professional tech writer to help on this. But here's my
> suggestion:
> "Unable to download. Please make sure the SIM card inserted is the one when
> this message was received."
> Thanks!

Hey Jenny,

Thanks! I've been just pointed out to Matej, who can help with it :)

Hi Matej,

Could you please confirm that the following error dialog text and title are OK for the case when user tries to download MMS content with the SIM different from one that was used to receive this MMS.

Title: 'Unable to download.'
Text: 'Please make sure the SIM card inserted is the one when this message was received.'

Thanks!

Comment 7

[Matej Novak [:matej]]

Hi Oleg,

Here's what I'm thinking for this:

Unable to download
Please make sure the SIM card inserted is the one used to receive this message.

How does that sound?

Comment 8

[Oleg Zasypkin [:azasypkin]]

(In reply to Matej Novak [:matej] from comment #7)
> Hi Oleg,
> 
> Here's what I'm thinking for this:
> 
> Unable to download
> Please make sure the SIM card inserted is the one used to receive this
> message.
> 
> How does that sound?

Yeah, sounds good!

Thanks!

Comment 9

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Julien,

This patch contains two commits, the first for the basic fix and the second one where I've tried to organize error code usage a bit. So it would be great to get your feedback on this.

Thanks!

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8451456 [details] [review]
GitHub pull request URL

I'm fine with the first commit but as discussed the refactoring is too complex for our needs.

Let's extract the error informations in its own file, keeping some of the changes you did (the Map for example), and either keep ErrorDialog like it is now, or make it take the Map value as parameter. (I don't quite know my preference yet)

Comment 11

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8451456 [details] [review]
GitHub pull request URL

(In reply to Julien Wajsberg [:julienw] from comment #10)
> Comment on attachment 8451456 [details] [review]
> GitHub pull request URL
> 
> I'm fine with the first commit but as discussed the refactoring is too
> complex for our needs.
> 
> Let's extract the error informations in its own file, keeping some of the
> changes you did (the Map for example), and either keep ErrorDialog like it
> is now, or make it take the Map value as parameter. (I don't quite know my
> preference yet)

Ok, as we agreed I've moved refactoring commit to a separate bug 1035279 and set r+ for the patch with first commit only.

Waiting for Travis...

Thanks!

Comment 12

[Oleg Zasypkin [:azasypkin]]

Master: https://github.com/mozilla-b2g/gaia/commit/97107ca63bad94b9238312869a3e360fc2dda037