1035624 - Promise constructor does not work on gaia try server

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: 0001-experiment.patch

we try to create Promise by constructor on bug 1029967 and it work well on local xulrunner, but it does not work on try server, attachment is a test cast to trigger failure.

now we use Promise.defer() as an workaround for this issue but hopely we can use promise constructor since it will be in es6 draft.[1]

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise#Specification

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

try server:

https://tbpl.mozilla.org/?rev=122277dfe95e29e2e0eea924b47a85b599b9288c&tree=Gaia-Try

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

and you can apply the patch and execute |make promise|, it works on local xulrunner.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Hmm, I would have thought that bug 1025731 should have fixed this.

jgriffin, missed configs/b2g/gaia_unit_production_config.py perhaps ?

Comment 4

[Jonathan Griffin (:jgriffin)]

(In reply to Nick Thomas [:nthomas] from comment #3)
> Hmm, I would have thought that bug 1025731 should have fixed this.
> 
> jgriffin, missed configs/b2g/gaia_unit_production_config.py perhaps ?

Right you are, I'll update it now.

Comment 5

[Jonathan Griffin (:jgriffin)]

Attachment: Update xre for gaia_unit tests,

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8452413 [details] [diff] [review]
Update xre for gaia_unit tests,

lgtm

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8452413 [details] [diff] [review]
Update xre for gaia_unit tests,

https://hg.mozilla.org/build/mozharness/rev/12ddabf24210

Comment 8

[Jonathan Griffin (:jgriffin)]

(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 8452413 [details] [diff] [review]
> Update xre for gaia_unit tests,
> 
> https://hg.mozilla.org/build/mozharness/rev/12ddabf24210

Pushed to production.  https://hg.mozilla.org/build/mozharness/rev/497dd135e8d7

John, can you merge this to your version of mozharness so it works on gaia-try?

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

done: http://hg.mozilla.org/users/jford_mozilla.com/mozharness/rev/8a90cc9ed444

Comment 10

[Jonathan Griffin (:jgriffin)]

Thanks.

Comment 11

[Pete Moore [:pmoore][:pete]]

Mozharness patch merged to production branch (https://hg.mozilla.org/build/mozharness/rev/497dd135e8d7)