1036307 - Overscroll effect breaks twitter pull to refresh

Status: RESOLVED WONTFIX

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect, P2)

Description

[Dale Harvey (:daleharvey)]

Putting in general since I dont know where to file this, since the scroll overflow was implement it has been hard to refresh the timeline in the twitter application as it uses pull to refresh, occasionally the pull to refresh is activated, but usually the overflow effect is shown and the twitter app doesnt refresh

Comment 1

[Dale Harvey (:daleharvey)]

Seems like a major issue, figured you would best know about where to get this flagged Jason

Comment 2

[Dale Harvey (:daleharvey)]

I dont think this is tech evangelism, we broke web content, there isnt anything to evangelise afaik?

Comment 3

[Jason Smith [:jsmith]]

(In reply to Dale Harvey (:daleharvey) from comment #2)
> I dont think this is tech evangelism, we broke web content, there isnt
> anything to evangelise afaik?

How did we break web content here? We need proof that this was working before to know that's in our problem to fix.

Comment 4

[Dale Harvey (:daleharvey)]

We broke web content when we landed the scroll overflow effect, the twitter application worked previous to it landing

Comment 5

[Jason Smith [:jsmith]]

Ok - I think we need a video of this bug to understand the user impact here.

Comment 6

[Eric Kramer [:Kramer]]

Video reproducing the issue: http://youtu.be/2HnsQuj4M-0 

Flame Master
BuildID: 20140711040202
Gaia: c47094a26c87ba71a3da4bae54febd0da21f3393
Gecko: 1b1296d00330
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Comment 7

[Jason Smith [:jsmith]]

We probably should branch check as well here.

Comment 8

[Joshua Mitchell (Inactive)]

This issue Reproduces in Flame 2.1, Flame 2.0, and Buri 2.1

Actual Result: Pulling down on the screen results in the overflow effect being seen instead of the twitter feed refresh (about 65% vs 35%)

Environmental Variables:

Device: Flame Master
Build ID: 20140721055837
Gaia: Unknown
Gecko: 0dc711216018
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Flame 2.0
Build ID: 20140721082721
Gaia: b9d19011123487009c80d1200937652d58c434a0
Gecko: d69cd84b6824
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Buri Master
Build ID: 20140721142028
Gaia: 649245c238a043af32acb109b2613f578323f8e1
Gecko: 5b64c42742cd
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

-------------------------------------------------------------------------------

This bug does NOT repro in Flame 1.4 
Device: Flame 1.4
Build ID: 20140721000201
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 83b7be7fb33f
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 9

[Jason Smith [:jsmith]]

Josh - I think you need to have a blocking triage analysis here.

Comment 10

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: Nomming as a blocker - issue creates a frustrating experience for users of a very popular app (twitter)


not adding regression-window: cause of issue is already known - overscroll effect

Comment 11

[Dale Harvey (:daleharvey)]

Chris Lord pointed out to me that this may not necessarily be a regression (sorry Jason), prior to overscroll landing pull to refresh commonly did nothing, the difference is now when the pull to refresh gesture is missed its visibly noticable

Either way the experience is very fustrating, but I think it does actually need to be fixed on twitter side

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

I seem to get more consistent behavior from the twitter pull refresh now.  If I make a fast swipe I get the refresh.  A slow swipe gives me the overscroll animation.  I have to pretty much intentionally perform the refresh swipe.  This is my experience on v2.0, though.

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

This is not actionable for graphics at this point - we can turn off overscroll for the whole device, if UX decides that's what should be done.  Alternatively, twitter can change the interface to not require pull-to-refresh. We do not have the CSS property to disable overscroll per element, which may be what the "proper" solution would be.  Is the element that needs to be pulled down to refresh scrollable?

Preeti, who can talk to twitter about this?  Jaime, assigning to you as UX needs to be involved if we're to disable overscroll overall.

Comment 14

[Jason Smith [:jsmith]]

(In reply to Milan Sreckovic [:milan] from comment #13)
> This is not actionable for graphics at this point - we can turn off
> overscroll for the whole device, if UX decides that's what should be done. 
> Alternatively, twitter can change the interface to not require
> pull-to-refresh. We do not have the CSS property to disable overscroll per
> element, which may be what the "proper" solution would be.  Is the element
> that needs to be pulled down to refresh scrollable?

Curious - Do we know if this problem happens on Firefox for Android? If it happens there, then I agree we should ask Twitter to fix this issue, as this ends up being a problem on their side, since they aren't taking overscroll into account in the platform vs. web content directly.

I'm adding qawanted to see if this happens on Firefox for Android.

> 
> Preeti, who can talk to twitter about this?  Jaime, assigning to you as UX
> needs to be involved if we're to disable overscroll overall.

Nicole would be a good person to talk about this on the content side - she probably knows who we could talk to on the Twitter side about the pull to refresh issue being problematic with overscroll enabled.

Comment 15

[Dale Harvey (:daleharvey)]

I tested Android, the same issue appears but much less obvious as the fx android overscroll doesnt move the content and pull to refresh is more reliable, possibly due to better hardware, it seems like a performance issue with the twitter code not correctly handling (and cancelling) events, even when it does work it is incredibly slow

The original report was mistaken, pull to refresh on twitter has always been broken, the difference is now it is more noticeable with overflow enabled

Comment 16

[Jason Smith [:jsmith]]

Just to clarify - We're saying that Twitter needs to fix this on their end, right? Do you agree with that? Just want to confirm before I move this over to the TE component.

Comment 17

[Dale Harvey (:daleharvey)]

Yup I agree with that, apologies for arguing otherwise when I initially reported it, I only started really noticing with overflow enabled

Comment 18

[Jason Smith [:jsmith]]

Ok - moving over to TE. I'm pulling the blocking flag here as well since this is an app issue per the analysis in the comments above, not FxOS issue.

Comment 20

[Nicole Fong]

Jeremy, please review.  Thank you!

Comment 21

[:Harald Kirschner :digitarald]

I understand from the discussion that pull-to-refresh is broken due to overscroll, but your comment says Twitter should fix it on their side. Do you have any input on what they need to fix?

I will verify that it works as expected without over-scroll. Otherwise it is just their over-scroll detection algorithm that is not consistently detecting over-scroll.

Comment 22

[Hubert Figuiere [:hub]]

FWIW, before there was overscroll, ie in 1.2 / 1.3, pull to refresh was already hard. not sure if I filed a bug back then when I was using Keon.

Comment 23

[Dale Harvey (:daleharvey)]

> I understand from the discussion that pull-to-refresh is broken due to overscroll, 
> but your comment says Twitter should fix it on their side. Do you have any input on what they need to fix?

As mentioned in the discussion, pull to refresh on twitter has always been very hard to trigger / commonly broken, the scroll events arent being detected and cancelled properly, the change to the overscroll effect just made those mistakes more visible (previously just nothing would happen)

Comment 24

[Sylvestre Ledru [:Sylvestre]]

Mass closing on Tech Evangelism::Preinstalled B2G App as Firefox OS is no longer a thing.

Comment 25

[Sylvestre Ledru [:Sylvestre]]

Mass closing on Tech Evangelism::Preinstalled B2G App as Firefox OS is no longer a thing.

Comment 26

[Sylvestre Ledru [:Sylvestre]]

Mass closing on Tech Evangelism::Preinstalled B2G App as Firefox OS is no longer a thing.