Closed Bug 1036517 Opened 6 years ago Closed 6 years ago

[geolocation-stumbler] Remove old stumbling code from GeckoApp.java

Categories

(Firefox for Android :: General, defect)

33 Branch
All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 33

People

(Reporter: garvan, Assigned: nalexander)

References

Details

Attachments

(1 file)

This code is no longer relevant. Should be trivial to remove.
I kept the existing preference UI since the new stumbler implementation
intends to use it.  I kept the pref listener since Bug 1036508 may elect
to keep using the existing Gecko pref.

blassey: you landed the initial code, so perhaps you're the right
reviewer.  Nothing touches the DOM geo API, but just in case I
verified that my location was reported to Google Maps correctly after
a build.
Attachment #8455834 - Flags: review?(blassey.bugs)
I should apologize for disparaging this code, sorry. Looking at it again now, seems reasonable, just looks like requirements moved forward and the code never got updated.
Attachment #8455834 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/12c90729d420
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/12c90729d420
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.