1037603 - Opening the dialer in RTL mode causes a visible direction switch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[(no longer active)]

The dialer first loads with the layout being LTR and then after it was loaded, it switches the direction of the UI, and that is quite noticeable.

Comment 1

[Stephany Wilkes]

Tim, can anyone take this for Dialer? If not please ni? me and I'll see if Pavel can take it, but I think this one may go beyond front-end issues.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Dialer is not under my team. Please ping the contact point of Comms team instead.

Comment 3

[Stephany Wilkes]

Hi Rik - Do you know who might be able to take this on?

Comment 4

[Anthony Ricaud (:rik)]

We have bug 1011731 in progress to always use the LTR layout for the keypad, even for RTL languages. I'm not familiar enough with RTL languages to know if it's a good practice. Ehsan: Could you help us know what's the best way to move forward here? See bug 1011731 comment 7.

Comment 5

[(no longer active)]

I would definitely expect the direction of the keypad to change for RTL, like this:

 3 2 1
 6 5 4
 9 8 7
 # 0 *

Comment 7

[Doug Sherk (:drs) (inactive)]

This is being caused by us lazy-loading the l10n.js library. Specifically, we import it here:
https://github.com/mozilla-b2g/gaia/blob/51e3d63754f3d9e765f811b7174d49bfa3a72d46/apps/communications/dialer/index.html#L77

Then l10n.js translates the document here:
https://github.com/mozilla-b2g/gaia/blob/51e3d63754f3d9e765f811b7174d49bfa3a72d46/shared/js/l10n.js#L1736

If I require l10n.js eagerly instead, the problem goes away.

I would prefer not to eagerly load l10n.js as it's such a massive library. My proposed solution to this is to separate out just the RTL logic into a new file, perhaps l10n_rtl.js, and eagerly load only that. I think that this would have lots of implications and impact many other apps, though. Zibi, Staś, what do you think?

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Why not just load it normally with defer? That makes the rtl part execute before firstpaint.

Comment 9

[Staś Małolepszy :stas]

Clearing the needinfo request on me for now.  Doug, feel free to flag me or Zibi again if 'defer' isn't a good solution here.

Comment 10

[Ahmed Nefzaoui [:Nefzaoui]]

Marking as fixed per Bug 1011731 comment 13 which is actually the current result shown up in the Dialer.

Comment 11

[Elie]

Verified successfully on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5d7497ce4cc7
Build-ID        20150120002507
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Reproduce rate 0/5
Refer to picture 2015-01-20-19-13-36.png

Comment 12

[Elie]

Attachment: 2015-01-20-19-13-36.png

Comment 13

[Delphine Lebédel [:delphine - Use needinfo]]

Marking as Verified fixed as per Comment 11

Comment 14

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15418/

Comment 15

[Stephany Wilkes]

Attachment: 2015-02-27-13-42-37.png

The Dialer layout is incorrect. Per the spec Rules of Thumb, numbers and numpads do not change direction (are not mirrored) in Arabic, because numerals are already, inherently Arabic numerals, and read LTR in Arabic. See screenshot. Dialer should not change in RTL.