103824 - News messages appear marked as unread after re-entering newsgroup

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Eric de Redelijkheid]

When I read a message in a newsgroup, the message is marked as read. When I
leave this newsgroup and, after a short while, come back to the same newsgroup,
this message appears again as unread. Marking the entire thread as read does not
help.

Build 2001100803

Comment 1

[Stephen Moehle]

I have the same problem on both Linux and Win2000.

Comment 2

[laurel]

*** Bug 103839 has been marked as a duplicate of this bug. ***

Comment 3

[John Hayward-Warburton]

Seeing this in 2001100908 on Linux as well. Leafnode is the server.

Comment 4

[scottputterman]

cc'ing bienvenu.  This sounds like what we wrote about earlier.

Comment 5

[David :Bienvenu]

OK, this is a sign of the success of my code to close db's after selecting a
different folder, and exposes a couple other bugs. We're closing the db without
committing the db, and we're still not trusting the newsrc file over the db.
News should probably commit the db after reading a message, but the catchall fix
would be to commit the db before closing it in the code that handles selecting a
different folder. I'll attach a patch in a sec.

Comment 6

[Eric Gerlach]

Sounds like this one is well in hand, but I'll add my gripe:
I get the same in Win98, with both 2001-09-30-trunk and 2001-10-08-trunk

Out of curiosity - why is this Unconfirmed?

Comment 7

[Ere Maijala (slow)]

Seeing this too on 2001100903 trunk Win2K. Sometimes messages stay marked as
read even after restarting Mozilla, but most of the time they come up unread.

Comment 8

[David :Bienvenu]

turns out to be a little more complicated - the news folder code which manages
the read set never expected the underlying db to get closed and never gets the
keyset out of it. The fix is going to be to give the db a pointer to the keyset,
which it will make changes to, but the folder will still own it, instead of the
copying and retrieving that goes on now.

Comment 9

[David :Bienvenu]

Attachment: proposed fix

Comment 10

[David :Bienvenu]

cc'ing navin for review.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 52921 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 12

[Navin Gupta]

r=naving, will this fix that annoying assertions when we search unread news
messages in debug build, boy, that is annoying. 

Comment 13

[David :Bienvenu]

No, it won't fix that assertion - that assertion is caused by the way search
opens the db for the news folder. I'll try to fix it.

Comment 14

[David :Bienvenu]

fix checked in.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 104078 has been marked as a duplicate of this bug. ***

Comment 16

[R.K.Aa.]

*** Bug 104155 has been marked as a duplicate of this bug. ***

Comment 17

[K Chayka]

*** Bug 104208 has been marked as a duplicate of this bug. ***

Comment 18

[laurel]

ok using oct26 commercial trunk build: win98, linux rh6.2, mac OS X

Comment 19

[Pete Boyd]

*** Bug 145682 has been marked as a duplicate of this bug. ***