Closed Bug 1038726 Opened 6 years ago Closed 6 years ago

[User Story] Change Rocketbar input type to replace Enter key

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86
macOS
defect
Not set

Tracking

(tracking-b2g:backlog, b2g-v2.0 wontfix, b2g-v2.1 affected)

RESOLVED FIXED
tracking-b2g backlog
Tracking Status
b2g-v2.0 --- wontfix
b2g-v2.1 --- affected

People

(Reporter: pdol, Assigned: benfrancis)

References

Details

(Keywords: feature, Whiteboard: [ucid:System227],[ft:systemsfe])

User Story

The input type for Rocketbar needs to be changed to make use of the change in bug 1038718.

Acceptance Criteria:
1. When focused on Rocketbar, the Enter key should change to the solution described by bug 1038718.

Attachments

(1 file)

No description provided.
Whiteboard: [ft:systemsfe] → [ucid:System227],[ft:systemsfe]
Blocks: browser-chrome-mvp
No longer blocks: rocketbar-search-mvp
Component: Gaia::Search → Gaia::System::Browser Chrome
This is all we need to change, right?

If so, I think we can safely land this before the dependencies land.
Attachment #8479184 - Flags: review?(kgrandon)
Assignee: nobody → bfrancis
Comment on attachment 8479184 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23325

Sure, I don't see any problems in landing this early.
Attachment #8479184 - Flags: review?(kgrandon) → review+
Tested this with the latest gaia and verified that it's working properly. Since the previous try was green, and the newest one was green-ish, going to land this to get it into master.

https://github.com/mozilla-b2g/gaia/commit/ab3b9d4460070ebfe4febc409cf341b14b08b9e2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.