1038775 - Always launch search activity on dashboard

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Eric Edens [:eedens]]

- On launch, don't focus search bar
- Clear last search every time the activity is loaded
- Always start the activity on the dashboard
- Don't show provider suggestions for empty query

Comment 1

[Eric Edens [:eedens]]

Removing query bar items, since bug 1035341 touches that code, and will cause a lot of conflicts.

New scope:
- On launch, don't focus search bar
- Always start the activity on the dashboard

Comment 2

[Eric Edens [:eedens]]

Attachment: bug-1038775.patch

Comment 3

[:Margaret Leibovic]

Comment on attachment 8456404 [details] [diff] [review]
bug-1038775.patch

Review of attachment 8456404 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/search/java/org/mozilla/search/MainActivity.java
@@ +27,3 @@
>      }
>  
>      private State state = State.START;

Not directly related to this bug, but is State.START ever used for anything? If not, I think we could just get rid of it.

Also, I find the terms "presearch" and "postsearch" a bit confusing. Do we even need states here? I would like to think about ways we can rename the fragments to be more intuitive. Perhaps something like InitialFragment and ResultsFragment? I'm having a tough time coming up with a good name for the first one.

Also, SearchFragment could probably be renamed to AutoCompleteFragment, since the whole activity is about searching, so using the term in there can be confusing.

Sorry for the digression, I'm just making my way through all this code right now :)

@@ +44,5 @@
> +    @Override
> +    protected void onResume() {
> +        super.onResume();
> +        // When the app launches, make sure we're in presearch *always*
> +        // Bug 1038775.

You don't need to include a bug number in a comment if it's the bug you're currently working on (blame can lead us back to this bug).

::: mobile/android/search/java/org/mozilla/search/PostSearchFragment.java
@@ -61,5 @@
>  
>      public void startSearch(String query) {
>          setUrl(Constants.YAHOO_WEB_SEARCH_BASE_URL + Uri.encode(query));
>      }
> -

Did you mean to remove this empty line?

Comment 4

[Eric Edens [:eedens]]

Attachment: bug-1038775.v2.patch

For the naming feedback -- I think you're right. There's a lot that we can do to make the structure more intuitive. I opened bug 1038924 for us to review that once the churn from this week settles.

ACK on the bug numbers, and thanks for catching that empty line.

Comment 5

[:Margaret Leibovic]

I'll let you merge the PR!

https://hg.mozilla.org/integration/fx-team/rev/2ba69933e5a5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ba69933e5a5

Comment 7

[Flaviu Cos]

Verified as fixed in build 34.0a1 (2014-08-04);
Device: Asus Transformer Tab (Android 4.2.1).