1038924 - Search activity: Review class names and packaging

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Eric Edens [:eedens]]

After the dust settles from the UI/UX work week, we should do a pass over the packaging and naming.

From bug 1038775: I find the terms "presearch" and "postsearch" a bit confusing. Do we even need states here? I would like to think about ways we can rename the fragments to be more intuitive. Perhaps something like InitialFragment and ResultsFragment? I'm having a tough time coming up with a good name for the first one.

Also, SearchFragment could probably be renamed to AutoCompleteFragment, since the whole activity is about searching, so using the term in there can be confusing.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Eric Edens [:eedens] from comment #0)
> After the dust settles from the UI/UX work week, we should do a pass over
> the packaging and naming.
> 
> From bug 1038775: I find the terms "presearch" and "postsearch" a bit
> confusing. Do we even need states here? I would like to think about ways we
> can rename the fragments to be more intuitive. Perhaps something like
> InitialFragment and ResultsFragment? I'm having a tough time coming up with
> a good name for the first one.

I don't like InitialFragment, 'cuz it doesn't say what it does.  It'll probably show recent searches, or suggested contents, or your location, or ...

SearchResultsFragment seems reasonable.

> Also, SearchFragment could probably be renamed to AutoCompleteFragment,
> since the whole activity is about searching, so using the term in there can
> be confusing.

Fine by me.

Comment 2

[:Margaret Leibovic]

(In reply to Nick Alexander :nalexander from comment #1)
> (In reply to Eric Edens [:eedens] from comment #0)
> > After the dust settles from the UI/UX work week, we should do a pass over
> > the packaging and naming.
> > 
> > From bug 1038775: I find the terms "presearch" and "postsearch" a bit
> > confusing. Do we even need states here? I would like to think about ways we
> > can rename the fragments to be more intuitive. Perhaps something like
> > InitialFragment and ResultsFragment? I'm having a tough time coming up with
> > a good name for the first one.
> 
> I don't like InitialFragment, 'cuz it doesn't say what it does.  It'll
> probably show recent searches, or suggested contents, or your location, or
> ...
> 
> SearchResultsFragment seems reasonable.

Well, in the future it may show more. We've been throwing around the term "dashboard" here, but that might imply more than what this fragment is actually doing. However, the things we've been talking about are all related to your search history, so maybe SearchHistoryFragment would work as a name.

Comment 3

[:Margaret Leibovic]

We're iterating on this as we go. Things are fine for now, we can change them in the bugs where we need them to be changed.