1040335 - Flip Unified Autocomplete pref once we merge to 34.

Status: VERIFIED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

We should do this after the merge, so we have full Nightly coverage.
I should also blog post before flipping the pref, to briefly explain what to expect.

I'll keep the r=ttaubert from bug 995092 on the patch to flip the pref.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 2

[Marco Bonardo [:mak]]

this is QA+ for the same reasons bug 995092 was.
Should go into the next iteration, since we can't land this until tuesday.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/8bb77d17d0ee

see also http://blog.bonardo.net/2014/07/24/unified-complete-coming-to-firefox-34

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8bb77d17d0ee

Comment 5

[Marco Mucci [:MarcoM]]

Hi Florin, can a QA contact be assigned for verification of this bug.

Comment 6

[Andrei Vaida [:avaida]]

Confirmed that the 'browser.urlbar.unifiedcomplete' pref is set to true on Nightly 34.0a1 (2014-07-27).

Marco, is there anything else I should be looking at for this specific bug?

Comment 7

[Marco Bonardo [:mak]]

(In reply to Andrei Vaida, QA [:avaida] from comment #6)
> Marco, is there anything else I should be looking at for this specific bug?

I think the idea was to have some basic smoketesting of the urlbar autocompletion to ensure there's nothing really "broken"

Comment 8

[Andrei Vaida [:avaida]]

(In reply to Marco Bonardo [:mak] from comment #7)
> I think the idea was to have some basic smoketesting of the urlbar
> autocompletion to ensure there's nothing really "broken"
Right, I thought there was a separate bug requiring that.

I ran a few tests around the Location Bar's autocomplete feature: general URL autocompletion, switch-to-tab and autocomplete history, targeting the general behavior of both regular and private windows. Tests performed on Nightly 34.0a1 (2014-07-29), using Windows 7 64-bit, Mac OS X 10.9.4 and Ubuntu 13.04 64-bit. 

There were no issues encountered, but I was wondering about the following behavior: switching from a (blank) new tab page to a different tab where a website is opened, closes that new tab page post-switch. This might be intended as it's the same all the way back to Firefox 4.0, but I thought I should mention it. 

What do you think?

Comment 9

[Marco Bonardo [:mak]]

(In reply to Andrei Vaida, QA [:avaida] from comment #8)
> (In reply to Marco Bonardo [:mak] from comment #7)
> > I think the idea was to have some basic smoketesting of the urlbar
> > autocompletion to ensure there's nothing really "broken"
> Right, I thought there was a separate bug requiring that.
> 
> I ran a few tests around the Location Bar's autocomplete feature: general
> URL autocompletion, switch-to-tab and autocomplete history, targeting the
> general behavior of both regular and private windows. Tests performed on
> Nightly 34.0a1 (2014-07-29), using Windows 7 64-bit, Mac OS X 10.9.4 and
> Ubuntu 13.04 64-bit. 
> 
> There were no issues encountered, but I was wondering about the following
> behavior: switching from a (blank) new tab page to a different tab where a
> website is opened, closes that new tab page post-switch. This might be
> intended as it's the same all the way back to Firefox 4.0, but I thought I
> should mention it. 

Yes, that's an intended feature to not leave empty tabs around.

I think this can be considered verified. Thank you.