Closed Bug 1041372 Opened 6 years ago Closed 6 years ago

[User Story] Rocketbar behavior for fullscreen apps with navigation chrome

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.1)

RESOLVED FIXED
2.1 S3 (29aug)
feature-b2g 2.1

People

(Reporter: pdol, Assigned: kgrandon)

References

Details

(Keywords: feature, Whiteboard: [ucid:System236], [systemsfe][tako])

User Story

This bug is to match the Rocketbar behavior for fullscreen apps with navigation chrome to the UX spec.

Acceptance Criteria:
1. The interaction and visual design for the Rocketbar for fullscreen apps with navigation chrome matches the UX spec.

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
No description provided.
[Blocking Requested - why for this release]:
blocking-b2g: backlog → ---
Whiteboard: [ucid:System236], [ft:systemsfe] → [ucid:System236], [systemsfe][tako]
Target Milestone: --- → 2.1 S1 (1aug)
Assignee: nobody → chrislord.net
Assignee: chrislord.net → 21
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
Flags: in-moztrap?(mozillamarcia.knous)
This just needs testing, but should be complete.
feature-b2g: 2.1 → ---
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Is it possible for QA to test Rocketbar on a fullscreen app with navigation chrome and check everything works?
Keywords: qawanted
I am unsure how to test this issue despite comment 3.  Is there any way you could provide steps for the QA team to properly test this feature?  Thank you!
Flags: needinfo?(pdolanjski)
(In reply to Duane Dixon [:ddixon] from comment #4)
> I am unsure how to test this issue despite comment 3.  Is there any way you
> could provide steps for the QA team to properly test this feature?  Thank
> you!

We need a test app which is fullscreen but also marks that it needs navigation chrome in the manifest.
Based on https://developer.mozilla.org/en-US/Apps/Build/Manifest, that means the following are set:
"fullscreen": "true"
"chrome": { "navigation": true }

Ben, can you confirm that what I described is accurate?
Flags: needinfo?(pdolanjski) → needinfo?(bfrancis)
Yes, that sounds right. Thanks Peter.
Flags: needinfo?(bfrancis)
feature-b2g: --- → 2.1
Not sure if anything is happening here, so I will take it.
Assignee: 21 → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request (obsolete) —
Comment on attachment 8480923 [details] [review]
Github pull request

Vivien or Ben - could one of you review this? Thanks!
Attachment #8480923 - Flags: review?(bfrancis)
Attachment #8480923 - Flags: review?(21)
Comment on attachment 8480923 [details] [review]
Github pull request

r+ with nits.
Attachment #8480923 - Flags: review?(21) → review+
Comment on attachment 8480923 [details] [review]
Github pull request

Reviewed by Vivien, thanks.
Attachment #8480923 - Flags: review?(bfrancis)
Master: https://github.com/mozilla-b2g/gaia/commit/4b95e413ab8df0ea4cd1beb54b18a91c81180d3d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attached file Github pull request
Now with a minor test modification to stub the app.config property. Carrying R+.
Attachment #8480923 - Attachment is obsolete: true
Attachment #8481552 - Flags: review+
Keywords: qawanted
You need to log in before you can comment on or make changes to this bug.