Closed Bug 1041516 Opened 6 years ago Closed 5 years ago

Don't allow Firefox to be the default browser but not check on startup to see if it's still the default browser

Categories

(Firefox :: Shell Integration, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36
Iteration:
36.1
Tracking Status
firefox36 --- verified

People

(Reporter: verdi, Assigned: Gavin)

References

Details

(Whiteboard: [fxgrowth])

Attachments

(2 files, 2 obsolete files)

Currently the default browser and check on startup preferences are independent. This can lead to someone choosing Firefox as their default browser without Firefox checking if it's default on startup. This makes it easy for any other software installation to change this pref and Firefox will never prompt the user to change it back. We should protect the user's intent when they made Firefox their default browser and not allow this combination of settings.
(In reply to Verdi [:verdi] from comment #0)
> Currently the default browser and check on startup preferences are
> independent. This can lead to someone choosing Firefox as their default
> browser without Firefox checking if it's default on startup. This makes it
> easy for any other software installation to change this pref and Firefox
> will never prompt the user to change it back. We should protect the user's
> intent when they made Firefox their default browser and not allow this
> combination of settings.

I've read this paragraph multiple times and still don't understand what you mean. Can you try to clarify, perhaps with step by step instructions as to what you think is going wrong where?
Flags: needinfo?(mverdi)
Component: General → Shell Integration
Hardware: x86 → All
Version: 32 Branch → Trunk
Sorry - it's hard to describe. I made a video to help explain - http://people.mozilla.org/~mverdi/video/default-notchecking.webm
Flags: needinfo?(mverdi)
Whiteboard: [fxgrowth]
Essentially, we should force-on "check on every startup" (browser.shell.checkDefaultBrowser) when you click "make firefox my default".
Flags: qe-verify+
Flags: firefox-backlog+
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8504973 - Flags: review?(benjamin)
Comment on attachment 8504976 [details] [diff] [review]
part 1: set the "Always ask" pref when setting ourselves as default

Review of attachment 8504976 [details] [diff] [review]:
-----------------------------------------------------------------

Mumble mumble code duplication.
Attachment #8504976 - Flags: review?(gijskruitbosch+bugs) → review+
Attachment #8504973 - Flags: review?(benjamin) → review+
Fixed a dumb bug in part 0 and repushed for windows only:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0d108509e2db
Needed to tweak a FUEL test that depended on browser.shell.checkDefaultBrowser being a user-set pref in the test environment (a previous test presumably calls setDefaultBrowser, which was setting the pref to true).
Attachment #8504976 - Attachment is obsolete: true
forgot one s/prefBranch/prefs/
Attachment #8504973 - Attachment is obsolete: true
Presumably I can override this is user.js?  Otherwise this breaks things for me.
Iteration: --- → 36.1
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 36.0a1 (buildID: 20141022030202).
Status: RESOLVED → VERIFIED
Blocks: 1088912
Depends on: 1144099
Depends on: 1532701
You need to log in before you can comment on or make changes to this bug.