Don't allow Firefox to be the default browser but not check on startup to see if it's still the default browser

VERIFIED FIXED in Firefox 36

Status

()

Firefox
Shell Integration
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: verdi, Assigned: Gavin)

Tracking

Trunk
Firefox 36
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify +

Firefox Tracking Flags

(firefox36 verified)

Details

(Whiteboard: [fxgrowth])

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Currently the default browser and check on startup preferences are independent. This can lead to someone choosing Firefox as their default browser without Firefox checking if it's default on startup. This makes it easy for any other software installation to change this pref and Firefox will never prompt the user to change it back. We should protect the user's intent when they made Firefox their default browser and not allow this combination of settings.

Comment 1

3 years ago
(In reply to Verdi [:verdi] from comment #0)
> Currently the default browser and check on startup preferences are
> independent. This can lead to someone choosing Firefox as their default
> browser without Firefox checking if it's default on startup. This makes it
> easy for any other software installation to change this pref and Firefox
> will never prompt the user to change it back. We should protect the user's
> intent when they made Firefox their default browser and not allow this
> combination of settings.

I've read this paragraph multiple times and still don't understand what you mean. Can you try to clarify, perhaps with step by step instructions as to what you think is going wrong where?
Flags: needinfo?(mverdi)

Updated

3 years ago
Component: General → Shell Integration
Hardware: x86 → All
Version: 32 Branch → Trunk
(Reporter)

Comment 2

3 years ago
Sorry - it's hard to describe. I made a video to help explain - http://people.mozilla.org/~mverdi/video/default-notchecking.webm
Flags: needinfo?(mverdi)
(Reporter)

Updated

3 years ago
Whiteboard: [fxgrowth]
Essentially, we should force-on "check on every startup" (browser.shell.checkDefaultBrowser) when you click "make firefox my default".
Flags: qe-verify+
Flags: firefox-backlog+
Created attachment 8504973 [details] [diff] [review]
part 0: clean up prefservice usage
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #8504973 - Flags: review?(benjamin)
Created attachment 8504976 [details] [diff] [review]
part 1: set the "Always ask" pref when setting ourselves as default
Attachment #8504976 - Flags: review?(gijskruitbosch+bugs)

Comment 6

3 years ago
Comment on attachment 8504976 [details] [diff] [review]
part 1: set the "Always ask" pref when setting ourselves as default

Review of attachment 8504976 [details] [diff] [review]:
-----------------------------------------------------------------

Mumble mumble code duplication.
Attachment #8504976 - Flags: review?(gijskruitbosch+bugs) → review+

Updated

3 years ago
Attachment #8504973 - Flags: review?(benjamin) → review+
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=cee00bcbbd59
Fixed a dumb bug in part 0 and repushed for windows only:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0d108509e2db
Created attachment 8507570 [details] [diff] [review]
part 1 with test fix

Needed to tweak a FUEL test that depended on browser.shell.checkDefaultBrowser being a user-set pref in the test environment (a previous test presumably calls setDefaultBrowser, which was setting the pref to true).
Attachment #8504976 - Attachment is obsolete: true
Created attachment 8507571 [details] [diff] [review]
part 0 with typo fix

forgot one s/prefBranch/prefs/
Attachment #8504973 - Attachment is obsolete: true
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=88f5d1599835
https://hg.mozilla.org/integration/fx-team/rev/cebde6059d78
https://hg.mozilla.org/integration/fx-team/rev/8222e6881da4
Flags: in-testsuite-
Target Milestone: --- → Firefox 36
Presumably I can override this is user.js?  Otherwise this breaks things for me.
https://hg.mozilla.org/mozilla-central/rev/cebde6059d78
https://hg.mozilla.org/mozilla-central/rev/8222e6881da4
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Iteration: --- → 36.1
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Nightly 36.0a1 (buildID: 20141022030202).
Status: RESOLVED → VERIFIED
status-firefox36: --- → verified
(Reporter)

Updated

3 years ago
Blocks: 1088912
Depends on: 1144099
You need to log in before you can comment on or make changes to this bug.