1042238 - Flip on Chromecast confvars by default

Status: VERIFIED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Running this through try:
https://tbpl.mozilla.org/?tree=Try&rev=9066908b04a5
(also without this patch, but with the new sdk) https://tbpl.mozilla.org/?tree=Try&rev=bc9a087e91e0

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8460412 [details] [diff] [review]
Patch

As long as the Try runs work

Comment 3

[Nick Alexander :nalexander [he/him]]

I expect this will require many developers to download new bits of the Android SDK, but the messaging at http://mxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#358 looks pretty good.  I just want to make a note on this ticket since it will likely be the bisection ticket people run into.

Comment 4

[Wesley Johnston (:wesj)]

try finally opened today! jdk1.7 is on the builders, so lets give this a second try.
https://tbpl.mozilla.org/?tree=Try&rev=1d1cb6a9c6be

Comment 5

[Wesley Johnston (:wesj)]

I think try looked good... it was reset slightly after, but the builds built. Landed this:
https://hg.mozilla.org/integration/fx-team/rev/f7faa1038cfc

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f7faa1038cfc

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8460412 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: New feature
[User impact if declined]: No casting videos to chromecast devices
[Describe test coverage new/current, TBPL]: There isn't much :(
[Risks and why]: This is medium risk because it flips on a new feature that's turned off otherwise. We had to hold off on flipping it while we got Google Play Services + JDK1.7 on the builder machines. Its there now. We want to ship casting/mirroring in FFAndroid 33.
[String/UUID change made/needed]: None.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Cool new feature
[Suggested wording]: Casting videos to Chromecast devices
[Links (documentation, blog post, etc)]:  Is there anything planed here?

Comment 9

[Flaviu Cos]

Verified as fixed in build 34.0a1 (2014-08-18);
Device: Asus Transformer Tab (Android 4.2.1).

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a566d0ba39d9

Comment 11

[Wesley Johnston (:wesj)]

forgot something. out of aurora for a minute:
https://hg.mozilla.org/releases/mozilla-aurora/rev/62397a1a0956

Comment 12

[Wesley Johnston (:wesj)]

SDK changes landed. Trying this again:
https://hg.mozilla.org/releases/mozilla-aurora/rev/49ab397b8c55

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Added in the 33 release notes with "Casting videos to Chromecast devices"

Comment 14

[Flaviu Cos]

Verified as fixed in build 33 beta 2;
Device: Google Nexus 7 (Android 4.4.4)