Closed Bug 1042238 Opened 6 years ago Closed 6 years ago
Flip on Chromecast confvars by default
No description provided.
Running this through try: https://tbpl.mozilla.org/?tree=Try&rev=9066908b04a5 (also without this patch, but with the new sdk) https://tbpl.mozilla.org/?tree=Try&rev=bc9a087e91e0
Attachment #8460412 - Flags: review?(mark.finkle)
Comment on attachment 8460412 [details] [diff] [review] Patch As long as the Try runs work
Attachment #8460412 - Flags: review?(mark.finkle) → review+
Component: General → Build Config & IDE Support
OS: Linux → Android
Hardware: x86_64 → All
Summary: Flip on chromecast confvars by default → Flip on Chromecast confvars by default
I expect this will require many developers to download new bits of the Android SDK, but the messaging at http://mxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#358 looks pretty good. I just want to make a note on this ticket since it will likely be the bisection ticket people run into.
try finally opened today! jdk1.7 is on the builders, so lets give this a second try. https://tbpl.mozilla.org/?tree=Try&rev=1d1cb6a9c6be
I think try looked good... it was reset slightly after, but the builds built. Landed this: https://hg.mozilla.org/integration/fx-team/rev/f7faa1038cfc
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment on attachment 8460412 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: New feature [User impact if declined]: No casting videos to chromecast devices [Describe test coverage new/current, TBPL]: There isn't much :( [Risks and why]: This is medium risk because it flips on a new feature that's turned off otherwise. We had to hold off on flipping it while we got Google Play Services + JDK1.7 on the builder machines. Its there now. We want to ship casting/mirroring in FFAndroid 33. [String/UUID change made/needed]: None.
Attachment #8460412 - Flags: approval-mozilla-aurora?
Release Note Request (optional, but appreciated) [Why is this notable]: Cool new feature [Suggested wording]: Casting videos to Chromecast devices [Links (documentation, blog post, etc)]: Is there anything planed here?
Attachment #8460412 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed in build 34.0a1 (2014-08-18); Device: Asus Transformer Tab (Android 4.2.1).
forgot something. out of aurora for a minute: https://hg.mozilla.org/releases/mozilla-aurora/rev/62397a1a0956
SDK changes landed. Trying this again: https://hg.mozilla.org/releases/mozilla-aurora/rev/49ab397b8c55
Verified as fixed in build 33 beta 2; Device: Google Nexus 7 (Android 4.4.4)
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 34 → mozilla34
You need to log in before you can comment on or make changes to this bug.