Closed Bug 1042616 Opened 11 years ago Closed 11 years ago

Give treeherder a favicon that shows tree open/closed state

Categories

(Tree Management :: Treeherder, defect, P2)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: camd, Mentored)

References

(
URL
)

Details

(Whiteboard: [good first bug])

Treeherder doesn't currently have a favicon. We should add one, and ideally one that changes based on the currently selected repo's open/closed state - for parity with TBPL (see bug 920869). This would also help with bug 1042613.
Blocks: 1042613
TBPL's favicon is extremely useful in both disambiguating TBPL from other tabs and communicating the status of the tree. As a tribute to everyone who contributed to TBPL, I propose using the same favicons as TBPL. :-)
TBPL assets: https://hg.mozilla.org/webtools/tbpl/raw-file/default/images/favicon.png https://hg.mozilla.org/webtools/tbpl/raw-file/default/images/favicon-treeclosed.png TBPL implementation: https://hg.mozilla.org/webtools/tbpl/file/479901292056/js/UserInterface.js#l196 Whilst using the TBPL assets would make a good short term solution, I'm wondering if we should try and find something that actually represents CI a bit more? Or at the least maybe a different colour to TBPL's shield, since it will make it easier to tell treeherder and TBPL tabs apart when side by side testing.
(In reply to comment #2) > Whilst using the TBPL assets would make a good short term solution, I'm > wondering if we should try and find something that actually represents CI a bit > more? You mean more representing than, a shield, err, or... hmm... a golden badge, or... whatever this is? Impossible! ;-) > Or at the least maybe a different colour to TBPL's shield, since it will > make it easier to tell treeherder and TBPL tabs apart when side by side > testing. That sounds like good idea.
Summary: Give treeherder a favicon → Give treeherder a favicon that shows tree open/closed state
Marking as good first bug w/jeads as mentor in case this is suitable for the upcoming work week, or the new development resources.
URL: https://treeherder.mozilla.org
Mentor: jeads
Whiteboard: [good first bug]
I do know a graphic designer who is interested in working on this (and possibly a logo for Treeherder) but she's going to be unavailable until the end of September. I don't want to discourage anybody else from picking up this bug though! :)
I think that still sounds good Dave. The last discussion I believe we had in channel was to just implement the existing TBPL favicon assets, which will address this as a blocker preventing sheriff adoption. After which, we could potentially keep this bug open but instead as a non-blocker for that graphic design work at the end of Sept.
Hey. I can work on this if it still involves implementing the TBPL favicon assets. Assign it to me
Hi Iulian! Just for reference this particular bug is an adoption blocker, so would need to be resolved relatively quickly (ie. probably measured in weeks) if that meets your schedule. Also the favicon implementation listed above in comment #2 is slightly more involved than just delivering the asset, it will need to differentiate the repo/tree state. If you'd prefer a longer timeline there are many other less time sensitive bugs you could also pick up from the "Non-blocking regressions" or "All others" bugs listed on the project page https://wiki.mozilla.org/Auto-tools/Projects/Treeherder Let us know which you prefer, if you'd still like this bug we can assign it to you. You can also find everyone on IRC moznet at #treeherder.
As I'm working on multiple things right now and I'm not that familiar with AngularJS maybe I should find a less time sensitive bug.
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
I'm going to just put a placeholder favicon set of assets. One for tree closed, another for open. Mostly, I'm implementing the angular logic to switch if the status changes. So we would love a "real" set of favicon assets. But this will do for now. My Photoshop-fu is not very good. So let's get nice images later this month.
fixed here: https://github.com/mozilla/treeherder-ui/commit/080a1646611730342c335cb226c54367a109f13f This uses a "generic" favicon. But the code logic is there to represent closed or open trees. I opened bug 1065488 to get better image assets.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 1065488
Depends on: 1077382
(In reply to Dave Hunt (:davehunt) from comment #5) > I do know a graphic designer who is interested in working on this (and > possibly a logo for Treeherder) but she's going to be unavailable until the > end of September. I don't want to discourage anybody else from picking up > this bug though! :) nb. we will be replacing the current simple 'Treeherder' text at the top left navbar with a functional 'Treeherder' menu in bug 1162706 for navigating various services current and future (eg. Perfherder). So I don't anticipate us needing a logo at least in that location. ie. outside of the favicon work camd describes.
You need to log in before you can comment on or make changes to this bug.