1042711 - Clicking away from a job in the main UI should close the job detail panel

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

Being able to click away from a job and free up the screen estate occupied by the job info panel is very useful in TBPL, would be great to be able to do this in treeherder too.

Comment 1

[Jonathan French (:jfrench)]

I have something kind-of working in preliminary form, I'll probably grab this bug for now. I am aware of the other two closely related bugs above, and may grab them later in the context of the work.

Comment 2

[Jonathan French (:jfrench)]

Ed, as part of this fix, I'd like to propose we make overflow in the result set list container hidden, just like TBPL. Any overly long li in the revision list would simply truncate at the boundary of the container. The tooltip would still show the entire string.

This will eliminate any (apparently complex and fringe) ways of bypassing a mouse event on a container overflow scroll bar. That event bypassing would otherwise be required, to prevent the closure of the job panel if the user accidentally or intentionally clicked on the scroll bar to scroll horizontal result set contents (ie. scrolling would be interpreted as a "close the job panel" event). As far as I can estimate, avoiding this issue is why TBPL does it also.

I have a working fix for this bug (closing the job panel on an empty space click), given that usability change.

Thoughts?

Comment 3

[Jonathan French (:jfrench)]

I spoke with Ed in channel, and he is fine with the idea of setting overflow hidden on the result set container (like TBPL does) for the reasons described above.

Comment 4

[Jonathan French (:jfrench)]

Attachment: treeherder-UI-PR#129

Please see the above PR for review and status.

Comment 5

[Jonathan French (:jfrench)]

Merged in master
https://github.com/mozilla/treeherder-ui/commit/cf894ea25a85f810611509f079f39f5e630c81d8

I will mark fixed once it's pushed and tested on dev/stage.

Comment 6

[Jonathan French (:jfrench)]

Appears to be fixed and working correctly on dev. Marking fixed prior to push to stage/prod.