1042646 - Closing the job detail panel should un-highlight the job

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

STR:
1) In the treeherder main UI, select a job
2) After the job detail panel appears in the lower third of the UI, close it by using the "x" top right of the panel.

Expected:
When the panel closes, the job symbol in the main UI is no longer highlighted.

Actual:
The job symbol is highlighted, but the panel is closed.

Comment 1

[Jonathan French (:jfrench)]

Just curious, I gather there is no benefit in 'knowing where you were' if you are working in other tabs and return to that treeherder page?

Comment 2

[Ed Morley [:emorley]]

(In reply to Jonathan French (:jfrench) from comment #1)
> Just curious, I gather there is no benefit in 'knowing where you were' if
> you are working in other tabs and return to that treeherder page?

At the moment, the "using several repos in one treeherder tab" workflow is too slow (both from a speed of pageload and hanging the browser on occasion), that it's hard to say for sure whether this would be useful, until we were using that workflow :-)

Comment 3

[Jonathan French (:jfrench)]

Sorry, I was actually referring to other non-treeherder tabs (doing some other activity), where when returning to the treeherder tab you would lose your sense of where you were. If that is a relevant workflow.

Comment 4

[Ed Morley [:emorley]]

Ah I follow now :-)
I find it helpful in TBPL to click away from a job (ie clear the data details panel) once I'm done with that failure, that way when I go to another tab and back, I know I've not still got something to do there.

Comment 5

[Jonathan French (:jfrench)]

A minor note as a result of the fix to bug 1042711, clicking away in empty body space any time after closing the job panel via its "x" icon, will also deselect the job (ie. one extra click beyond the desired behavior in this bug).

And from that fixed bug - clicking away in empty space will both close the job panel(if open) and deselect the job. So the entire document body becomes a target area to achieve the desired "x" behavior.

Not to say we don't want to fix the "x" and make it consistent but there are several workarounds present.

Comment 6

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#260

Please see the above PR for review and status.

Comment 7

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/3c7aa14d848d32a278d6aa81d4d6d860bdb32f3c
Bug 1042646 - Deselect job when closing job panel

https://github.com/mozilla/treeherder-ui/commit/02d376eb4b7f0ac42032c6ec9e8ec8798802b874
Merge pull request #260 from tojonmz/deselect-job-panel-close

Bug 1042646 - Deselect job when closing job panel

Comment 8

[Jonathan French (:jfrench)]

Verified fixed and working correctly on stage on Firefox 33.1. Unable to verify on Chrome due to bug 1072346 (job panel not opening).

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f60f2147efe2998bbdeb8c30e5776a4d151b6de0
Bug 1042646 - Deselect job when closing job panel

https://github.com/mozilla/treeherder/commit/e89ee517383edb331460ee602227f2ede9a9bffe
Merge pull request #260 from tojonmz/deselect-job-panel-close

Bug 1042646 - Deselect job when closing job panel