1042804 - Refine about:home colors to be consistent with new toolbar style

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

I saw this screenshot, and I think that the color of the tab strip in about:home doesn't look quite right with the new color of the toolbar:

https://www.dropbox.com/s/c18hwbymmeykilr/new-toolbar.png

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: toolbar_compare1.png

Yeah - I noticed this too as I was working on it. As a starting point, I'm going to post a comparison screenshot here. I've been experimenting with #F5F5F5 as the background color for the panel labels background in about:home.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Refine about:home colors to be consistent with new toolbar style (r=margaret)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8472962 [details] [diff] [review]
Refine about:home colors to be consistent with new toolbar style (r=margaret)

Use #F5F5F5 as suggested by antlam.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Here's how it looks.

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

hmm I like it. At first glance, I felt as though it was quite a stark difference.. but I think it makes the content in the panels stand out a bit more rather than competing with our bluish hue. Thoughts?

Comment 6

[:Margaret Leibovic]

Comment on attachment 8472962 [details] [diff] [review]
Refine about:home colors to be consistent with new toolbar style (r=margaret)

Review of attachment 8472962 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Anthony Lam (:antlam) from comment #5)
> hmm I like it. At first glance, I felt as though it was quite a stark
> difference.. but I think it makes the content in the panels stand out a bit
> more rather than competing with our bluish hue. Thoughts?

Yeah, looks good to me.

Comment 8

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/dd1a8ebbfae3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e

Comment 10

[Lucas Rocha (:lucasr)]

The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/821e2da4fb7e

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/821e2da4fb7e

Comment 12

[Lucas Rocha (:lucasr)]

Comment on attachment 8472962 [details] [diff] [review]
Refine about:home colors to be consistent with new toolbar style (r=margaret)

Approval Request Comment
[Feature/regressing bug #]: bug 1010740
[User impact if declined]: Inconsistent UI colors used in reader mode. Makes us look amateur.
[Describe test coverage new/current, TBPL]: It's been in Nightly for a few days. Looking good.
[Risks and why]: Low, the patch simple changes colors in CSS and updates on image used in the UI. 
[String/UUID change made/needed]: n/a

Comment 13

[Lucas Rocha (:lucasr)]

Comment on attachment 8472962 [details] [diff] [review]
Refine about:home colors to be consistent with new toolbar style (r=margaret)

Wrong bug, apologies for the spam.