1042879 - [rtl] Lockscreen: display camera icon on the left when passcode is displayed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Comparison (top current, bottom patched)

Currently, camera icon is displayed on the right like LTR when passcode is enabled.

This causes also a weird alignment of hour/date, since the camera is hidden but space is still occupied (bug 998137).

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8461051 [details] [review]
Pull request on Github

Code is simple and it looks nice (except one nit). However, please set UI review to make sure they have no further opinions.

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8461051 [details] [review]
Pull request on Github

Amy, can you take at this fix?

Comment 4

[Amy Lee [:amylee] UX]

Comment on attachment 8461051 [details] [review]
Pull request on Github

It there a reason that the date and time is aligned to the right and the status bar is aligned to the left?

Also, I noticed that the "1" in the keypad doesn't aligned with the other numbers in the keypad. Not sure if this needs to be filed as a separate issue.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Amy Lee [:amylee] from comment #4)
> It there a reason that the date and time is aligned to the right and the
> status bar is aligned to the left?

I think that's expected, it's specular to what happens on LTR. The same happens when the screen is unlocked.
@Ahmed, can you confirm that's expected?

> Also, I noticed that the "1" in the keypad doesn't aligned with the other
> numbers in the keypad. Not sure if this needs to be filed as a separate
> issue.

I didn't notice that, but definitely a separate bug in gaia::keyboard.

Comment 6

[Amy Lee [:amylee] UX]

(In reply to Francesco Lodolo [:flod] from comment #5)
> (In reply to Amy Lee [:amylee] from comment #4)
> > It there a reason that the date and time is aligned to the right and the
> > status bar is aligned to the left?
> 
> I think that's expected, it's specular to what happens on LTR. The same
> happens when the screen is unlocked.
> @Ahmed, can you confirm that's expected?
> 
> > Also, I noticed that the "1" in the keypad doesn't aligned with the other
> > numbers in the keypad. Not sure if this needs to be filed as a separate
> > issue.
> 
> I didn't notice that, but definitely a separate bug in gaia::keyboard.

Hi Francesco, 

I've filed a separate bug for the keyboard issue (Bug 1043563).

Comment 7

[Ahmed Nefzaoui [:Nefzaoui]]

Yes(In reply to Francesco Lodolo [:flod] from comment #5)
> (In reply to Amy Lee [:amylee] from comment #4)
> > It there a reason that the date and time is aligned to the right and the
> > status bar is aligned to the left?
> 
> I think that's expected, it's specular to what happens on LTR. The same
> happens when the screen is unlocked.
> @Ahmed, can you confirm that's expected?

Yes it is the expected behavior for the RTL view.
Basically RTL is all about "mirroring" so if an object in LTR is aligned to the left, it should be right-aligned in RTL, and vice versa. :)

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8461051 [details] [review]
Pull request on Github

Thanks Ahmed.

Setting ui-review again, I don't think there's anything else blocking considering that the keyboard issue is now tracked in a different bug.

Comment 9

[Amy Lee [:amylee] UX]

Comment on attachment 8461051 [details] [review]
Pull request on Github

Thanks for the fix!

Comment 10

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/7306065260ceabd3138e4524e53670460c2c4e5f

Comment 11

[Francesco Lodolo [:flod]]

Verified on flame

Gaia      c8511217183ade630f5afa7698c04efef5c6806b
Gecko     https://hg.mozilla.org/mozilla-central/rev/a4dcfbebcb58
BuildID   20140728040209
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014