964037 - (gaia-rtl) Support RTL for Lockscreen App

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P2)

Description

[Ahmed Nefzaoui [:Nefzaoui]]

This bug is set for tracking and fixing everything related to Right-To-Left issues in Lockscreen.
PS: I prefer holding on for this until Lockscreen becomes a complete separate App.
Work is tracked in Bug 898348

Comment 1

[Stephany Wilkes]

Ahmed, I'd like to get this assigned. Let me know if you can take it or if I should find a SysFE developer. Thanks!

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Github pull-request

Yes, taking.. :)
PR ready, Lockscreen is generally OK, just a little nit.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8469819 [details] [review]
Github pull-request

Make sure Greg know this.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8469819 [details] [review]
Github pull-request

OK, for me it's a simple change. And sorry for the delay of making LockScreen as an app. After we encountered the serious testing issue, which delayed the patch and let us miss the possible window to merge it without too much conflicts, the patch to make it as an app now is deprecated. The new plan is to make it as an test app first at Bug 1039211.

And I think this needs UI review to make sure it is OK for UX?

Comment 5

[Stephany Wilkes]

This is fine with UX. Let's land and uplift as possible; this is low risk and small.

Comment 6

[Stephany Wilkes]

Ahmed or Alive, please request approval for uplift and include the required comments. Thanks!

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

The bug assignee should do the request.

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: After Patch - 2014-09-25-00-27-47

Rebased the patch
And here's a screenshot for ui-review.
Stephany,
Could you take a look at it please?
Thanks

Comment 9

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8469819 [details] [review]
Github pull-request

Sorry I'm asking for review again. Made few changes and thought they need a review too.
Seems like another bug did most of the work so there was no need anymore for RTL-specific changes except for one -moz-margin-start and -moz-padding-start
Thanks

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8469819 [details] [review]
Github pull-request

Glad to learn -moz-padding-start

Comment 11

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/16a0bae181aee4ba0780674103c49a2bf54089d4

Comment 12

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: [v2.1] Link to Github pull-request

Requesting uplifting to 2.1 as requested by UX.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No actual bug, was broken since ever because RTL was never took into account before.
[User impact] if declined: Time in lockscreen will look shifted away of its RTL position (far right)
[Testing completed]: On device, Flame
[Risk to taking this patch] (and alternatives if risky): No.
[String changes made]: No.

Comment 13

[Stephany Wilkes]

Comment on attachment 8494625 [details]
After Patch - 2014-09-25-00-27-47

Looks great. UX approved. Thank you, Ahmed!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6d72f2ab10098f730e3b428dfb2ce87dcd02b141

Comment 15

[Sue]

Could you provide the detailed reproduce steps or video for me to verify this bug. Thanks!

Comment 16

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: The time display is located on the right properly.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141202001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-------------------------------------------------

This issue STILL reproduces on Flame 2.2.

Result: The camera icon is located on the right, and the time display is shifted towards left.

Device: Flame 2.2 (319mb, KK, Full Flash)
BuildID: 20141202040207
Gaia: 725685831f5336cf007e36d9a812aad689604695
Gecko: 2c9781c3e9b5
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Filed a new bug 1106879.

Comment 17

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]

Comment 18

[Sue]

According to comment 16, this issue is verified on Flame 2.1, clears the needinfo request. 
We could trace it on bug 1106879

Comment 19

[Sue]

Attachment: screenshot.png

This issue has been verified fail on Flame 2.2, the camera icon is located on the right, but the time display is shifted towards left. We could also see bug 1106879
See attachment:screenshot.png and logcat_v2.2_1241.txt

Flame 2.2 build:
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Build-ID        20150114002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150114.040029
FW-Date         Wed Jan 14 04:00:40 EST 2015
Bootloader      L1TC000118D0

Comment 20

[Sue]

Attachment: logcat_v2.2_1241.txt

Comment 21

[Sue]

Attachment: screenshot_v2.1.png

Hi Josh,
This is the screenshot of Flame 2.1, the camera icon is located on the left, and the time is located on the right. I can't make sure if it is correct. Could you help with it? Thanks!

Flame 2.1 build:
Gaia-Rev        6957ac8a322234ec99c8abb7cc18dc6a2e0176db
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/6600eba54256
Build-ID        20150114001300
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150114.035135
FW-Date         Wed Jan 14 03:51:46 EST 2015
Bootloader      L1TC000118D0

Comment 22

[Josh Cheng [:josh]]

Hi Sue,
I marked "verifyme" with batch process but did not notice your comment 18. I think you can track the fix on 2.2 from bug 1106879. Thanks!

Comment 23

[Sue]

Hi Josh,
I'm sorry that I had a wrong understanding. Thanks!

Comment 24

[Shine(Leave from Mozilla)]

Hi Ahmed,
This problem can be repro on latest build of Flame 2.2.
See attachment: Flame2.2_Screenshot.png & logcat_1311.txt
Repro time: 13:11
Rate: 5/5

Flame 2.2 build:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/75a462a58d7a
Build-ID        20150121002607
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.040751
FW-Date         Wed Jan 21 04:08:02 EST 2015
Bootloader      L1TC000118D0

Comment 25

[Shine(Leave from Mozilla)]

Attachment: Flame2.2_Screenshot

Comment 26

[Shine(Leave from Mozilla)]

Attachment: logcat

Comment 27

[howie [:howie]]

Hi Greg, can you help on this? Ahmed's account seems not in use anymore. Thanks.

Comment 28

[Greg Weng [:snowmantw][:gweng][:λ]]

Hmm. I guess this is yet another "let me do this when I'm interested in" bug. Could we have an offline discussion? Since I don't really know the details.

Comment 29

[howie [:howie]]

Just found Ahmed is using other account. Hi Ahmed, is there any update on this? Thanks.

Comment 30

[Ahmed Nefzaoui [:Nefzaoui]]

Hey all,
Sorry if this has not been explicitly said here, but this bug has became a meta, which means there's no actual steps to reproduce it but rather fix all it's children bugs to finally be closed. :)
Let me know if there's anything else needed here.
Thanks!

Comment 31

[Stephany Wilkes]

Ahmed, I think people are asking because of the attachment field on this bug and all of the + patches. Flagging Ahmed and Kaze to see if those patches should be uplifted, etc. If so, and all is ready to go, let's resolve this even though it's a meta.

Comment 32

[Elie]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15863/

Comment 33

[BMO Automation]

Firefox OS is not being worked on