Red and italic font used for newtab tiles' titles looks rather cheap

VERIFIED FIXED in Firefox 33

Status

()

Firefox
New Tab Page
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: Mardak)

Tracking

Trunk
Firefox 34
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox33 verified, firefox34 verified)

Details

Attachments

(5 attachments)

(Reporter)

Description

4 years ago
Created attachment 8461559 [details]
Screenshot of the new tab page

The new design from bug 1036284 is nice but the new red and italic font used for pinned tiles looks quite cheap. I don't see it in the PDF from bug 1030832 either.

The red font does seem to grab a lot more attention than necessary and doesn't play nicely with the blue border, imo.

Where does this come from? Is that really the desired style? Can we talk about this again?
Flags: needinfo?(edilee)
Flags: needinfo?(athornburgh)
(Reporter)

Comment 1

4 years ago
FTR, found the red font on page 7 in the aforementioned PDF file.
Since the background of the pin button remains blue when a tile gets pinned, might I suggest using dark blue text instead?

Comment 3

4 years ago
Besides the title-colors(red == error, imho), shouldn't the border-radius use the color specified as an highlight-color(eg. in OS X, System Preferences > General).

afaik. most_ parts in Firefox respect this property?
(Reporter)

Comment 4

4 years ago
Created attachment 8461634 [details]
Screenshot with black font (#4A4A4A)

Here's a screenshot with using #4A4A4A (the color we use when hovering unpinned tiles) as the default color for pinned tiles. I like that a little more and the difference is more subtle.
(Assignee)

Comment 5

4 years ago
(In reply to Tim Taubert [:ttaubert] from comment #1)
> FTR, found the red font on page 7 in the aforementioned PDF file.
Nod. https://bug1030832.bugzilla.mozilla.org/attachment.cgi?id=8446620 Page 7 "And this is what pinned tiles should look like." And bug 1037341 comment 1
Flags: needinfo?(edilee)
(Assignee)

Comment 6

4 years ago
(In reply to Blake Winton (:bwinton) from comment #2)
> Since the background of the pin button remains blue when a tile gets pinned,
> might I suggest using dark blue text instead?
The pinned state will actually end up being black (#231f20) and the blue pinned is only on hover: https://bug1036284.bugzilla.mozilla.org/attachment.cgi?id=8454562

But that seems reasonable to make the pinned text be the same #231f20.
(Assignee)

Comment 7

4 years ago
Created attachment 8461667 [details]
#231f20: hovered bold/italics, bold, italics, nobold/italics

Here's how things look with the same color as the pinned state (#231f20) and various options of bold and italics.

Comment 8

4 years ago
Ok, I'm over the italics. Keep the bold. Make it blue.
Flags: needinfo?(athornburgh)
(Assignee)

Comment 9

4 years ago
(In reply to Aaron from comment #8)
> Make it blue.
Which blue? And will it clash with the sponsored/ad text that potentially overlaps with the title text? https://bug1040369.bugzilla.mozilla.org/attachment.cgi?id=8461277
Flags: needinfo?(athornburgh)

Comment 10

4 years ago
The label should NOT be blue or say "Ad". The only label we are doing is gray text on off-white.

The title of a pinned tiles should be bold and HEX# 2C72C4 (dark blue).
Flags: needinfo?(athornburgh)
(Assignee)

Comment 11

4 years ago
Created attachment 8461718 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8461718 - Flags: review?(adw)
(Assignee)

Comment 12

4 years ago
Created attachment 8461720 [details]
v1 screenshot
(Assignee)

Updated

4 years ago
Blocks: 977787, 1030832
Points: --- → 1
Flags: firefox-backlog+

Updated

4 years ago
Attachment #8461718 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/8341fd0ede34
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34

Updated

4 years ago
Iteration: --- → 34.1
QA Whiteboard: [qa?]
QA Whiteboard: [qa?] → [qa+]
QA Contact: cornel.ionce
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0
Mozilla/5.0 (X11; Linux i686; rv:34.0) Gecko/20100101 Firefox/34.0

Verified fixed on Windows 7 64bit, Windows 8.1 64bit (Microsoft Surface Pro 2), Ubuntu 12.04 and Mac OS X 10.9.3 using latest Nightly, build ID: 20140727030204.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
(Assignee)

Updated

4 years ago
Blocks: 1057602
Uplift has been managed in bug 1057602
status-firefox33: --- → fixed
status-firefox34: --- → verified
(Assignee)

Updated

4 years ago
status-firefox33: fixed → affected
(Assignee)

Updated

4 years ago
status-firefox33: affected → fixed
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0

Verified fixed on Windows 7 64bit, Mac OS X 10.8.5 and Ubuntu 14.04 32bit using latest Aurora, build ID: 20140828004002.
status-firefox33: fixed → verified
You need to log in before you can comment on or make changes to this bug.