1044060 - [MobileID] Add Mobile ID test to Gaia UI test app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

We need a simple UI test to exercise the navigator.getMobileIdAssertion call. This will allow us to do manual and automatic (marionette) functional tests.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22481

Comment 2

[Zac C (:zac)]

Actually this is not a test app, it's just a standalone app. I'm not a dev so probably not the best person to review it, sorry ferjm!

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Ok, thanks anyway, Zac.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8466992 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22481

This is good for functional test, but not for marionette tests. Please create another drop-in app in the test script for that purpose.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Thanks Tim!

https://github.com/mozilla-b2g/gaia/commit/d6c7edf333fab56210348bb7471d0c5a7b57497e

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

[Blocking Requested - why for this release]: This would help testing Mobile ID issues on 2.0. We are only adding a test app for functional tests, so there is no risk involved in this uplift.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #6)
> [Blocking Requested - why for this release]: This would help testing Mobile
> ID issues on 2.0. We are only adding a test app for functional tests, so
> there is no risk involved in this uplift.

Fernando - a test only change actually doesn't need approval for uplift - just add a=test only to the commit message and you should automatically be able to uplift the patch. In terms of blocking, I don't we would block on this mainly because it's not part of the build.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Excellent! Thanks for the info Jason.

https://github.com/mozilla-b2g/gaia/commit/9637977e6d141426c99bbcaa742f4a819c57f6a7