1044406 - Tap on notification does nothing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

With current master on my Nexus S, tapping on a notification does nothing.

STR:
 0. Receive a SMS
 1. Pull down notification tray
 2. Tap SMS notification

Expected:
 Messages application gets launched.

Actual:
 Nothing happens.

Comment 1

[:gerard-majax]

Doing a local revert of bug 1041383 fixes the regression for me.

Comment 2

[Chris Lord [:cwiiis]]

Attachment: Don't listen to 'tap' event without GestureDetector

Whoops - I should've tested better after removing GestureDetector in my original patch. I don't think using GestureDetector just for a tap makes sense so I've implemented it in the existing touch handling.

Comment 3

[Salvador de la Puente González [:salva]]

Comment on attachment 8463382 [details] [review]
Don't listen to 'tap' event without GestureDetector

As I was fixing bug 1007413 (which it became a dup of this), be careful with tests, they should fail with your current solution because you removed the `tap` event.

IMHO, you could emit a synthetic `tap` event instead of calling .tap() in `touchend` and restore the `tap` case. This way, the behaviour remains almost unaltered but you get rid of all the complexity from GestureDetector.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: Gaia PR, use tap event without Gesture Detector

Alex, can you take a look? There are two commits in this PR because I wanted to preserve credit/blame for the different pieces.

Comment 7

[:gerard-majax]

Comment on attachment 8463687 [details] [review]
Gaia PR, use tap event without Gesture Detector

Thanks, it works well when testing this. I'm happy that we can re-enable some tests, but can we ensure that they do not trigger new intermittence?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/ec80df3247ef00d5382c59255a5e46b5d45494e6

(In reply to Alexandre LISSY :gerard-majax from comment #7)
> Comment on attachment 8463687 [details] [review]
> Gaia PR, use tap event without Gesture Detector
> 
> Thanks, it works well when testing this. I'm happy that we can re-enable
> some tests, but can we ensure that they do not trigger new intermittence?

Yeah, we will have to watch this test and make sure it does not trigger new intermittents. But, we absolute need this test to avoid smoke test regressions like this bug.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I just pulled today's gaia and this is fixed.

Comment 10

[Martin Shuman [:Marty]]

Adding smoketest keyword.

Comment 11

[Martin Shuman [:Marty]]

Verified as fixed in Flame 2.1
Tapping sms notifications opens the messaging app appropriately.

Environmental Variables:
Device: Flame 2.1
BuildID: 20141021001201
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Gecko: ee86921a986f
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0