1044737 - Pass timestamp instead in nsINetworkStatsCallback::networkStatsAvailable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #1043830 +++

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Find also in NetworkUtils::getNetworkInterfaceStats, but we never pass such command to NetworkWorker or so since bug 948743.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 1/3: don't use Date in nsINetworkStatsCallback::networkStatsAvailable

1) We don't depend on NetdWorker for this command anymore. /proc is always available so we don't have to check |this.shutdown| in this case.
2) Refactor the code a little bit.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2/3: remove unused bits related to 'getNetworkInterfaceStats'

Remove anything only referenced by NetworkUtils::getNetworkInterfaceStats. These should had been removed before bug 864931 was ever landed.

This patch also removes redundant fields from WebIDL dictionary NetworkCommandOptions and NetworkResultOptions.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 3/3: fix NetworkStatsService::networkStatsAvailable and test cases

The interface no longer passes Date object but we still have to construct it back in NetworkStatsService.jsm because it's required by |NetworkStatsDB.normalizeDate|. Further removal of these Date objects maybe addressed in bug 1043830.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

https://tbpl.mozilla.org/?tree=Try&rev=39538c1620c1

Comment 6

[Bobby Holley (:bholley)]

Comment on attachment 8463243 [details] [diff] [review]
part 2/3: remove unused bits related to 'getNetworkInterfaceStats'

Review of attachment 8463243 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me on the webidl change.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 1/3: don't use Date in nsINetworkStatsCallback::networkStatsAvailable : v2

Fix typo in XPIDL file.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Re-try on emulator targets: https://tbpl.mozilla.org/?tree=Try&rev=7c4258b2dbf1

Comment 9

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8463833 [details] [diff] [review]
part 1/3: don't use Date in nsINetworkStatsCallback::networkStatsAvailable : v2

Review of attachment 8463833 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e0335a065983
https://hg.mozilla.org/integration/b2g-inbound/rev/002eb34f27dc
https://hg.mozilla.org/integration/b2g-inbound/rev/ae9adb97f886

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e0335a065983
https://hg.mozilla.org/mozilla-central/rev/002eb34f27dc
https://hg.mozilla.org/mozilla-central/rev/ae9adb97f886