1045217 - [10.10] Tooltips have an incorrect color: yellow, but should be grey

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[José Jeria]

Build ID:Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:34.0) Gecko/20100101 Firefox/34.0

STR:
Hover any tab to see a tooltip with the website's full title/name

Actual results:
Tooltips are yellow

Expected results:
Tooltips should be grey like the rest of the tooltips in OS X 10.10

Comment 1

[:Gijs (he/him)]

In my VM, the background is #f0f0f0, but I don't know whether the tooltips are using vibrancy/transparency, as the VM doesn't show any. In any case, the code that needs updating is here: http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsNativeThemeCocoa.mm#2327 .

We could also do with slightly more horizontal padding on the tooltips.

Comment 2

[:Gijs (he/him)]

Attachment: tooltip-transparency.png

This should use the behind-window vibrancy on OS X. I expect the simplest will be to just update the -moz-appearance here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/popup.css#101

although I wonder if instead we should not change -moz-appearance: tooltip to use behind-window-vibrancy in cocoa instead... That seems cleaner and would also mean other apps/themes/things-with-moz-appearance-tooltip automatically benefit from the update. I'd be happy to look at this myself - Markus, could you give a pointer or two on how to do that, or is that trickier than it sounds? :-)

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> I'd be happy to look at this myself -
> Markus, could you give a pointer or two on how to do that, or is that
> trickier than it sounds? :-)

Comment 4

[Stefan [:stefanh]]

FYI, we don't do more than just paint the yellow background-color for "-moz-appearance: tooltip;"

-----------------------------------
2374     case NS_THEME_TOOLTIP:
2375       CGContextSetRGBFillColor(cgContext, 0.996, 1.000, 0.792, 0.950);
2376       CGContextFillRect(cgContext, macRect);
2377       break;

Comment 5

[:Gijs (he/him)]

(In reply to Stefan [:stefanh] from comment #4)
> FYI, we don't do more than just paint the yellow background-color for
> "-moz-appearance: tooltip;"
> 
> -----------------------------------
> 2374     case NS_THEME_TOOLTIP:
> 2375       CGContextSetRGBFillColor(cgContext, 0.996, 1.000, 0.792, 0.950);
> 2376       CGContextFillRect(cgContext, macRect);
> 2377       break;

Yes, I know - I tried to point out as much in comment #1 . But as you can see from the screenshot, this is no longer "just" transparency, but there's some blurring involved as well. To get this right, we should use the behind-window vibrancy implemented in bug 1055614.

Comment 6

[Markus Stange [:mstange]]

(In reply to :Gijs Kruitbosch from comment #2)
> Markus, could you give a pointer or two on how to do that, or is that
> trickier than it sounds? :-)

It's not - should be rather simple, actually. In nsNativeThemeCocoa, don't paint anything for NS_THEME_TOOLTIP if VibrancyManager::SystemSupportsVibrancy(), and add NS_THEME_TOOLTIP handling near the places NS_THEME_MAC_VIBRANCY_LIGHT is used in nsDisplayList.cpp and nsChildView.mm.

Comment 7

[:Gijs (he/him)]

Attachment: vibrancy for tooltips,

Per discussion on IRC, this is a start, but we need to (at a minimum) tell OS X that we want vibrancy even when the tooltip (window) doesn't have focus.

Comment 8

[:Gijs (he/him)]

Markus, do you have time to look at this "soon" ? If not, shall I put up a patch to at least adjust the color to a transparent grey so it doesn't look quite so harshly out of place, that we can uplift for 34? :-)

Comment 9

[Markus Stange [:mstange]]

Last time I looked at this I wasn't able to make tooltips use vibrancy, no matter what I tried.
So yes, adjusting the color would be the right short-term fix.

Comment 10

[:Gijs (he/him)]

Attachment: fix 10.10 tooltips to use grey instead of yellow,

This looks right to me on my actual 10.10 machine in terms of transparency/shade of gray.

Comment 11

[Markus Stange [:mstange]]

Comment on attachment 8498171 [details] [diff] [review]
fix 10.10 tooltips to use grey instead of yellow,

That's a very white-looking grey you have there.

Comment 12

[:Gijs (he/him)]

Yeah, checked in with more grey-ish grey (but still pretty non-grey).

remote:   https://hg.mozilla.org/integration/fx-team/rev/124797ab4a5c


Twiddling lots of flags for backlog things. Marco, can you add this? (bug 1063714 is currently blocked, and I worked on this (important for yosemite stuff) when I didn't know I was going to need to back out bug 1057166 - I'll get back to that tonight / tomorrow, as this is done now)

I'll file a separate bug for making this use proper translucency.

Comment 13

[Marco Mucci [:MarcoM]]

Added to IT 35.3

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/124797ab4a5c

Comment 15

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 35
Build Id: 20141002030202
Os: Mac Os X 10.10

Comment 16

[:Gijs (he/him)]

Comment on attachment 8498171 [details] [diff] [review]
fix 10.10 tooltips to use grey instead of yellow,

Approval Request Comment
[Feature/regressing bug #]: yosemite
[User impact if declined]: really bright yellow tooltips in a gone-grey-and-translucent OS
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: pretty low; uses a different color somewhere in widget instead of the one it uses now
[String/UUID change made/needed]: nope

NB: please transplant the landed patch instead of the one on the bug.

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8498171 [details] [diff] [review]
fix 10.10 tooltips to use grey instead of yellow,

Aurora+

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

[Tracking Requested - why for this release]:

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/998c8b3e358c

Comment 20

[Catalin Varga [QA][:VarCat]]

Verified as fixed using:

FF34
Build Id: 20141009004002
OS: Mac Os X 10.10