1075653 - [10.10] Tooltips should use vibrancy (translucency) on Yosemite

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[:Gijs (he/him)]

There's a partial patch in bug 1045217.

Comment 1

[Markus Stange [:mstange]]

The reason I wasn't able to get vibrancy working was because borderless windows only get vibrancy on those pixels for which the alpha value is at least 1 (of 255), and I was clearing the background completely.

Comment 2

[:Gijs (he/him)]

(In reply to Markus Stange [:mstange] from comment #1)
> The reason I wasn't able to get vibrancy working was because borderless
> windows only get vibrancy on those pixels for which the alpha value is at
> least 1 (of 255), and I was clearing the background completely.

How hard is it to fix this? I imagine we'll run into this for the context menus as well...

Comment 3

[Markus Stange [:mstange]]

I have tooltips and context menus working locally now. Cleaning up the patches next...

Comment 4

[Markus Stange [:mstange]]

Attachment: patch

Comment 5

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8503215 [details] [diff] [review]
patch

This looks fine to me, but I have a nit:

+@interface NSView(NSVisualEffectViewSetState)
+- (void)setState:(NSUInteger)state;
+@end

I can see why you did this.  But it's confusing and needs explanation.

The NSView class doesn't have setState method even on Yosemite, or a state property.  The state property belongs to the NSVisualEffectView class, which is present only on Yosemite (and up), and is only defined when using the Yosemite SDK.  It's in effect undefined using other (earlier) SDKs.  So for usages of it to compile there, you need to add a category as for an undocumented method, and the NSView class is a convenient place to add it.

Comment 6

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ad2da5715e8

I forgot to add the comment you requested. I'll land it as a follow-up.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ad2da5715e8

Comment 8

[Kartikaya Gupta (email:[e-mail])]

This patch appears to have broken my build on OS X 10.9.5. Do I need to upgrade XCode or something? Relevant portion of the build log at https://pastebin.mozilla.org/8847697

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Oh sorry, the changes from this bug just generate warnings. It's a different patch that generated the error. Never mind.