1045461 - Failed to build Vixen with m-c Gecko, BluetoothServiceBluedroid.cpp:204:5: error: invalid conversion from 'void (*)()' to 'void (*)(mozilla::dom::bluetooth::BluetoothProfileResultHandler*)'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp: In member function 'virtual nsresult CleanupTask::Run()':
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:204:5: error: invalid conversion from 'void (*)()' to 'void (*)(mozilla::dom::bluetooth::BluetoothProfileResultHandler*)' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp: In function 'void RemoteDevicePropertiesCallback(bt_status_t, bt_bdaddr_t*, int, bt_property_t*)':
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:569:18: warning: pointer of type 'void *' used in arithmetic [-Wpointer-arith]
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp: In member function 'virtual void InitResultHandler::Init()':
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:911:5: error: invalid conversion from 'void (*)()' to 'void (*)(mozilla::dom::bluetooth::BluetoothProfileResultHandler*)' [-fpermissive]

Comment 1

[Jenny Liu[:jennyliu]]

This should be vixen issue, modify the dependency and whiteboard tag.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1045461: Fix HFP fallback code to work with latest Bluetooth changes

Vicamo,

Does this patch fix the problem? I don't have a tablet; can't test.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1045461: Fix HFP fallback code to work with latest Bluetooth changes (under bluetooth2/)

Same patch for bluetooth2/

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8463848 [details] [diff] [review]
[02] Bug 1045461: Fix HFP fallback code to work with latest Bluetooth changes (under bluetooth2/)

Review of attachment 8463848 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8463847 [details] [diff] [review]
[01] Bug 1045461: Fix HFP fallback code to work with latest Bluetooth changes

Review of attachment 8463847 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the quick fix :)

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks a lot! This got delayed a bit by b2g-inbound being closed, but should land now.

https://hg.mozilla.org/integration/b2g-inbound/rev/fd7b28405e87
https://hg.mozilla.org/integration/b2g-inbound/rev/447914859ecd

https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=447914859ecd

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd7b28405e87
https://hg.mozilla.org/mozilla-central/rev/447914859ecd