Closed Bug 1045461 Opened 7 years ago Closed 7 years ago

Failed to build Vixen with m-c Gecko, BluetoothServiceBluedroid.cpp:204:5: error: invalid conversion from 'void (*)()' to 'void (*)(mozilla::dom::bluetooth::BluetoothProfileResultHandler*)'

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S1 (1aug)

People

(Reporter: vicamo, Assigned: tzimmermann)

References

Details

(Whiteboard: [vixen])

Attachments

(2 files)

../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp: In member function 'virtual nsresult CleanupTask::Run()':
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:204:5: error: invalid conversion from 'void (*)()' to 'void (*)(mozilla::dom::bluetooth::BluetoothProfileResultHandler*)' [-fpermissive]
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp: In function 'void RemoteDevicePropertiesCallback(bt_status_t, bt_bdaddr_t*, int, bt_property_t*)':
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:569:18: warning: pointer of type 'void *' used in arithmetic [-Wpointer-arith]
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp: In member function 'virtual void InitResultHandler::Init()':
../../../gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:911:5: error: invalid conversion from 'void (*)()' to 'void (*)(mozilla::dom::bluetooth::BluetoothProfileResultHandler*)' [-fpermissive]
Blocks: 1045424
Assignee: nobody → tzimmermann
This should be vixen issue, modify the dependency and whiteboard tag.
Blocks: vixen
No longer blocks: flatfish
Whiteboard: [vixen]
Vicamo,

Does this patch fix the problem? I don't have a tablet; can't test.
Attachment #8463847 - Flags: review?(shuang)
Attachment #8463847 - Flags: feedback?(vyang)
Comment on attachment 8463848 [details] [diff] [review]
[02] Bug 1045461: Fix HFP fallback code to work with latest Bluetooth changes (under bluetooth2/)

Review of attachment 8463848 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8463848 - Flags: review?(btian) → review+
Comment on attachment 8463847 [details] [diff] [review]
[01] Bug 1045461: Fix HFP fallback code to work with latest Bluetooth changes

Review of attachment 8463847 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the quick fix :)
Attachment #8463847 - Flags: feedback?(vyang) → feedback+
https://hg.mozilla.org/mozilla-central/rev/fd7b28405e87
https://hg.mozilla.org/mozilla-central/rev/447914859ecd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in before you can comment on or make changes to this bug.