1046044 - "Reddit Enhancement Suite" add-on does not work with e10s

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect)

Description

[kaankasim88]

Extension doesn't load at all.

Comment 1

[Chris Peterson [:cpeterson]]

kaankasim, thanks for testing. I'll update our list of add-ons.

Comment 2

[Steve Sobel]

does anyone have specifics on what sorts of errors there are yet, etc?  I'd certainly like to get this resolved (I'm the core author of RES)

Comment 3

[Chris Peterson [:cpeterson]]

kaankasim, can you please share any error messages you see logged in Firefox's Browser Console?

Steve, you can enable e10s in Nightly channel builds be flipping the about:config pref "browser.tabs.remote.autostart" to true and restarting Firefox. When e10s is enabled, add-ons run in the parent/chrome process by default. Because RES modifies web content, you will need to add code that runs in the content/child process sandbox.

MDN also has a good introduction to e10s for add-on developers. If you have any more questions, just drop by the #e10s IRC channel on irc.mozilla.org.

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Comment 4

[kaankasim88]

There is nothing on the console other than "Use of getPreventDefault() is deprecated.  Use defaultPrevented instead." which shows in non e10s window too.  It is from res though, it doesn't show up  when disabled.

Comment 5

[Steve Sobel]

I'm not finding any interesting/useful error messages, all I'm getting is:

System JS : ERROR resource://gre/modules/AddonManager.jsm:20 - Error: You cannot use the AddonManager in child processes!

that's not my code, of course, and I'm not directly referencing AddonManager, nor is there any sort of interesting / useful trace that can tell me what I'm using that's referencing the AddonManager.

Any tips on further debugging would be appreciated.

Comment 6

[Chris Peterson [:cpeterson]]

You will need to move any RES code that reads or modifies web content to "frame scripts" that run in the sandboxed content process. The best place to get help is on #e10s IRC channel on irc.mozilla.org. MDN has more more information here:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Yes, the AddonManager error message is unrelated to your code.

Comment 7

[John Schoenick [:johns]]

RES appears to be using jetpack, which has known issues with e10s

Specifically, their onContent hook for inserting pagemods is broken:
http://dxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/page-mod.js#48

So there's not much point worrying about brokenness in jetpack addons until bug 930164 is resolved (and we should mention that before telling any addon authors to fix their stuff)

Comment 9

[Alex]

RES actually works for me (36.0a1 (2014-11-23) on OS X).

Comment 10

[Chris Peterson [:cpeterson]]

Thanks for testing Alexander. This addon was probably fixed by some recent e10s changes to improve addon compatibility.

Comment 11

[Alex]

FYI, it's broken again in 2015-02-22's Nightly. From what the debugger says, the add-on is completely missing from the source list, so probably not loaded at all. All is fine in a non-e10s window, though.

Comment 12

[Alex]

And it works again in 2015-02-26's Nightly.