popupWindowURI got changed into an nsIURI object for some reason. (Nobody ever uses it, they just want the spec. Sigh...)
The notification.xml change is because the new page report sometimes gets notified even when there isn't a new popup. Unfortunately the test looks a little odd because of bug 1047111; depending on what happens in that bug, I might be able to simplify the test.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8465843 - Flags: review?(philip.chee)
Comment on attachment 8465843 [details] [diff] [review] Proposed patch r=me > - if (!browser.blockedPopups) > + if (!browser.blockedPopups || browser.blockedPopups.reported != false) Let's see. We have an array, blockedPopups, that also has a JS property "reported". But this patch appears to be working. BTW where do we call browser.updateBlockedPopups() ?
Attachment #8465843 - Flags: review?(philip.chee) → review+
(In reply to Philip Chee from comment #2) > BTW where do we call browser.updateBlockedPopups() ? We don't; each notificationbox tracks its own browser's blocked popups, whereas in Firefox the tabbrowser tracks blocked popups for all browsers and has to force an update when you switch tabs.
a=me for CLOSED TREE
Comment on attachment 8465843 [details] [diff] [review] Proposed patch [Triage Comment] a=me
Attachment #8465843 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.