Closed
Bug 1047114
Opened 10 years ago
Closed 10 years ago
Fix popup blocker fallout from bug 1024391
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(seamonkey2.30 fixed, seamonkey2.31 fixed)
RESOLVED
FIXED
seamonkey2.31
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
1.75 KB,
patch
|
philip.chee
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
popupWindowURI got changed into an nsIURI object for some reason. (Nobody ever uses it, they just want the spec. Sigh...)
Assignee | ||
Comment 1•10 years ago
|
||
The notification.xml change is because the new page report sometimes gets notified even when there isn't a new popup. Unfortunately the test looks a little odd because of bug 1047111; depending on what happens in that bug, I might be able to simplify the test.
Assignee | ||
Updated•10 years ago
|
status-seamonkey2.30:
--- → affected
status-seamonkey2.31:
--- → affected
Comment 2•10 years ago
|
||
Comment on attachment 8465843 [details] [diff] [review] Proposed patch r=me > - if (!browser.blockedPopups) > + if (!browser.blockedPopups || browser.blockedPopups.reported != false) Let's see. We have an array, blockedPopups, that also has a JS property "reported". But this patch appears to be working. BTW where do we call browser.updateBlockedPopups() ?
Attachment #8465843 -
Flags: review?(philip.chee) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Philip Chee from comment #2) > BTW where do we call browser.updateBlockedPopups() ? We don't; each notificationbox tracks its own browser's blocked popups, whereas in Firefox the tabbrowser tracks blocked popups for all browsers and has to force an update when you switch tabs.
Comment on attachment 8465843 [details] [diff] [review] Proposed patch [Triage Comment] a=me
Attachment #8465843 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 6•10 years ago
|
||
Pushed comm-central changeset 2394d3a13705.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.31
Assignee | ||
Comment 7•10 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/5330b28fac6c
You need to log in
before you can comment on or make changes to this bug.
Description
•