enable "user story" field on all products

RESOLVED FIXED

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgong, Assigned: dkl)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
A couple of bugs filed but upon edit, bugzilla doesn't show the user story field for Product enter user story. 2 bug

https://bugzilla.mozilla.org/show_bug.cgi?id=1010743

https://bugzilla.mozilla.org/show_bug.cgi?id=865789
(Reporter)

Updated

5 years ago
Assignee: nobody → dkl
(Reporter)

Comment 1

5 years ago
Even for this bug itself.  When I edit this bug I don't see the user story field.
(Reporter)

Comment 2

5 years ago
It seems like when this original request was implemented Bug 963793  fix to have user story field available on bug creation.  The user story field was make available only to bugs filed under the Product category for Firefox OS. All the other categories for Core, Firefox, Firefox for Android, Firefox for Metro, Marketplace etc.. do not show the user story field upon bug creation.  You would need to make the user story field available for all these other product categories.
(Assignee)

Comment 3

5 years ago
Posted patch 1047131_1.patch (obsolete) — Splinter Review
Attachment #8466395 - Flags: review?(glob)
(Reporter)

Comment 4

5 years ago
(In reply to David Lawrence [:dkl] from comment #3)
> Created attachment 8466395 [details] [diff] [review]
> 1047131_1.patch

Can you let me know when this fix will be pushed to production?
OS: Mac OS X → All
Hardware: x86 → All
Summary: bugs created in bugzilla doesn't show the user story field. → enable "user story" field on all products
Comment on attachment 8466395 [details] [diff] [review]
1047131_1.patch

Review of attachment 8466395 [details] [diff] [review]:
-----------------------------------------------------------------

the user-story field isn't visible on enter_bug for products with an empty exclude-components list (i suggest restoring the block at the start of toggleUserStory and negating the logic).

::: extensions/UserStory/Extension.pm
@@ +43,5 @@
> +            }
> +            else {
> +                # If we are in enter_bug and there are specific exclude components,
> +                # we show the field as it will be filtered out in the template
> +                $self->{user_story_exclude_components} = $exclude_components;

as $exclude_components is always an empty array at this point there's no need to reference it here, or declare it outside of the if() block
Attachment #8466395 - Flags: review?(glob) → review-
(Assignee)

Comment 6

5 years ago
Attachment #8466395 - Attachment is obsolete: true
Attachment #8467804 - Flags: review?(glob)
(Assignee)

Comment 7

5 years ago
(In reply to Jean Gong from comment #4)
> Can you let me know when this fix will be pushed to production?

We are currently reviewing the second revision of this change so it will most likely be next
week's push that will contain the change if no other major fixes are needed. Pushes normally
happen around Tuesdays.

dkl
Comment on attachment 8467804 [details] [diff] [review]
1047131_2.patch

Review of attachment 8467804 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: extensions/UserStory/lib/Constants.pm
@@ +22,5 @@
> +#   'Firefox OS' => [],
> +#   'Firefox'    => ['Developer Tools'],
> +use constant USER_STORY_EXCLUDE => {
> +    'Firefox'    => [],
> +    'Firefox OS' => ['Bluetooth']

i assume these exclusions are a result of debugging, and shouldn't be part of this patch.
Attachment #8467804 - Flags: review?(glob) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   b9b4791..ec10d05  master -> master
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

5 years ago
(In reply to Byron Jones ‹:glob› from comment #8)
> > +    'Firefox'    => [],
> > +    'Firefox OS' => ['Bluetooth']
> 
> i assume these exclusions are a result of debugging, and shouldn't be part
> of this patch.

Yep :) Thanks for fixing and pushing it out.

dkl
this is now live on production.
You need to log in before you can comment on or make changes to this bug.